Skip to content

fix: sshare testing as an alternative to sacctmgr account tests #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 15, 2025
Merged

fix: sshare testing as an alternative to sacctmgr account tests #178

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f035b0e
fix: introduced sshare testing as an alternative to sacctmgr account …
cmeesters Dec 11, 2024
100da58
fix: linting
cmeesters Dec 11, 2024
41292fb
Merge branch 'main' into fix/sshare-alternative
cmeesters Jan 9, 2025
5b2612b
fix: hopefully right secret name for mastodon post
cmeesters Jan 9, 2025
82eda26
Update snakemake_executor_plugin_slurm/__init__.py
johanneskoester Jan 14, 2025
8a10415
fix: made a full sentence of the error report, if both sacctmgr and s…
cmeesters Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions snakemake_executor_plugin_slurm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,10 +555,15 @@ def test_account(self, account):
cmd, shell=True, text=True, stderr=subprocess.PIPE
)
except subprocess.CalledProcessError as e:
raise WorkflowError(
f"Unable to test the validity of the given or guessed SLURM account "
f"'{account}' with sacctmgr: {e.stderr}"
)
sacctmgr_report = f"Unable to test the validity of the given or guessed SLURM account '{account}' with sacctmgr: {e.stderr}."
try:
cmd = "sshare -U --format Account --noheader"
accounts = subprocess.check_output(
cmd, shell=True, text=True, stderr=subprocess.PIPE
)
except subprocess.CalledProcessError as e:
sshare_report = "Unable to test the validity of the given or guessed SLURM account '{account}' with sshare: {e.stderr}."
raise WorkflowError(sacctmgr_report + " - and - " + sshare_report)

# The set() has been introduced during review to eliminate
# duplicates. They are not harmful, but disturbing to read.
Expand Down
Loading