Skip to content

fix: ci runner ought to start now upon merge to main #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

cmeesters
Copy link
Member

@cmeesters cmeesters commented Jan 18, 2025

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow to trigger Mastodon posting on pull request closure for the main branch
    • Refined workflow event configuration to improve automation precision

Copy link
Contributor

coderabbitai bot commented Jan 18, 2025

Walkthrough

The GitHub Actions workflow for posting to Mastodon has been reconfigured to trigger on pull request closure events specifically for the main branch. The workflow now listens for pull_request events with a closed type, focusing exclusively on the main branch. The core functionality of checking if the pull request was merged and executing the Mastodon posting script remains consistent with the previous implementation.

Changes

File Change Summary
.github/workflows/post_to_mastodon.yml Workflow trigger changed from push to pull_request with closed event type, explicitly scoped to main branch

Possibly related PRs

Poem

🐰 A Workflow's Whisker-Twitch Tale

From push to pull, the trigger shifts
Main branch awaits its Mastodon gifts
Closed PRs dance, a coding delight
Automation hops with rabbit might! 🚀


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e1d9a1 and 08f6cc5.

📒 Files selected for processing (1)
  • .github/workflows/post_to_mastodon.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: testing
🔇 Additional comments (2)
.github/workflows/post_to_mastodon.yml (2)

4-8: LGTM! Workflow trigger configuration is correct.

The change from push to pull_request with closed type and main branch restriction properly captures merge events to the main branch.


Line range hint 22-24: Verify the retry action version.

The retry mechanism configuration looks good, but let's verify we're using the latest version of nick-fields/retry action.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cmeesters cmeesters merged commit 90c6bf9 into main Jan 18, 2025
6 checks passed
@cmeesters cmeesters deleted the ci/Mastodon branch January 18, 2025 20:20
cmeesters pushed a commit that referenced this pull request Jan 20, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.14.2](v0.14.1...v0.14.2)
(2025-01-20)


### Bug Fixes

* ci runner ought to start now upon merge to main
([#189](#189))
([90c6bf9](90c6bf9))
* path to access the posting script
([#191](#191))
([d7dcbbb](d7dcbbb))
* path to posting script
([#193](#193))
([d0fb3cd](d0fb3cd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@cmeesters cmeesters restored the ci/Mastodon branch January 22, 2025 07:17
cmeesters added a commit that referenced this pull request Jan 22, 2025
again, because the last PR (#189 ) did not start, see
https://github.com/snakemake/snakemake-executor-plugin-slurm/actions/runs/12902576814

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
	- Updated GitHub Actions workflow syntax for Mastodon post job
	- Improved conditional expression formatting in workflow configuration

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant