chore(main): release 1.2.0 #247
Conversation
WalkthroughThis PR updates the Snakemake executor plugin for SLURM from version 1.1.0 to 1.2.0. It adds a new version entry in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
6-8: Minor Language Suggestion
Consider hyphenating "case insensitive" to "case‐insensitive" for consistency with standard English style guidelines. This would ensure uniformity in technical documentation.🧰 Tools
🪛 LanguageTool
[misspelling] ~8-~8: This word is normally spelled with a hyphen.
Context: ...v1.1.1) (2025-03-27) ### Bug Fixes * case insensitive matching of declared slurm account ([#...(EN_COMPOUNDS_CASE_INSENSITIVE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[misspelling] ~8-~8: This word is normally spelled with a hyphen.
Context: ...v1.1.1) (2025-03-27) ### Bug Fixes * case insensitive matching of declared slurm account ([#...
(EN_COMPOUNDS_CASE_INSENSITIVE)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: testing
🔇 Additional comments (2)
pyproject.toml (1)
1-3: Version Bump Verification
The version has been updated to "1.1.1" as expected for the release. This change correctly aligns with the PR objective and appears consistent with the project conventions.CHANGELOG.md (1)
3-4: New Release Entry Added
The new version entry for 1.1.1, dated 2025-03-27, is well formatted and provides clear context for this release.
snakemake-bot
force-pushed
the
release-please--branches--main
branch
from
0f4afba to
0063c71
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
11-13: Bug Fix Entry Verified
The Bug Fixes section correctly reiterates the fix for case insensitive matching of declared Slurm accounts with the relevant issue ([#244]) and commit hash (dc9a4fd).
Suggestion: Consider hyphenating "case insensitive" to "case‐insensitive" to align with standard compound adjective styling.🧰 Tools
🪛 LanguageTool
[misspelling] ~13-~13: This word is normally spelled with a hyphen.
Context: ...9789cb7058dde98013)) ### Bug Fixes * case insensitive matching of declared slurm account ([#...(EN_COMPOUNDS_CASE_INSENSITIVE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[misspelling] ~13-~13: This word is normally spelled with a hyphen.
Context: ...9789cb7058dde98013)) ### Bug Fixes * case insensitive matching of declared slurm account ([#...
(EN_COMPOUNDS_CASE_INSENSITIVE)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: testing
🔇 Additional comments (2)
CHANGELOG.md (2)
3-4: New Version Header Added
The new version header for version 1.2.0 is formatted correctly with a proper comparison link and the accurate release date (2025-03-31) that aligns with the PR objectives.
6-8: Features Section Correctly Documented
The Features section clearly lists the new 'qos' resource with its corresponding issue ([#241]) and commit hash (c8cdfc4). This accurately reflects the new functionality introduced in this release.
snakemake-bot
force-pushed
the
release-please--branches--main
branch
from
0063c71 to
1283fcc
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
6-8: New Feature: "qos" ResourceThe feature entry documenting the addition of the new 'qos' resource is clear and includes the relevant issue (#241) and commit reference. Consider adding a brief explanatory note about the purpose or impact of the 'qos' resource if not already covered in the documentation.
11-15: Bug Fixes Documentation CheckThe bug fix entries are well detailed with proper issue references and commit hashes. However, on line 14, consider changing "case insensitive matching of declared slurm account" to "case‑insensitive matching of declared slurm account" to align with standard spelling conventions.
🧰 Tools
🪛 LanguageTool
[misspelling] ~14-~14: This word is normally spelled with a hyphen.
Context: ...8f4aeb50886535f13f5b8d4b56036951d87)) * case insensitive matching of declared slurm account ([#...(EN_COMPOUNDS_CASE_INSENSITIVE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[misspelling] ~14-~14: This word is normally spelled with a hyphen.
Context: ...8f4aeb50886535f13f5b8d4b56036951d87)) * case insensitive matching of declared slurm account ([#...
(EN_COMPOUNDS_CASE_INSENSITIVE)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: testing
🔇 Additional comments (1)
CHANGELOG.md (1)
3-4: New Version Entry for 1.2.0The new version header for 1.2.0 and the corresponding date are well formatted and provide clear release context.
snakemake-bot
force-pushed
the
release-please--branches--main
branch
from
1283fcc to
f4b9551
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
11-15: Bug Fixes Section Documents Corrections with Clear References
The Bug Fixes section accurately reflects the corrections for account and partition settings ([#249]) as well as for case insensitive matching of declared Slurm accounts ([#244]).
Suggestion: Consider changing “case insensitive matching of declared slurm account” to “case‐insensitive matching of declared Slurm account” to conform with standard hyphenation and capitalization conventions.🧰 Tools
🪛 LanguageTool
[misspelling] ~14-~14: This word is normally spelled with a hyphen.
Context: ...8f4aeb50886535f13f5b8d4b56036951d87)) * case insensitive matching of declared slurm account ([#...(EN_COMPOUNDS_CASE_INSENSITIVE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[misspelling] ~14-~14: This word is normally spelled with a hyphen.
Context: ...8f4aeb50886535f13f5b8d4b56036951d87)) * case insensitive matching of declared slurm account ([#...
(EN_COMPOUNDS_CASE_INSENSITIVE)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: testing
🔇 Additional comments (2)
CHANGELOG.md (2)
3-4: Version Entry for 1.2.0 is Correctly Formatted
The new version entry for 1.2.0 follows the established format with a proper URL diff link and the correct release date, "2025-04-04".
6-9: Features Section Accurately Documents the 'qos' Resource
The Features section clearly states that a new 'qos' resource was added, referencing issue [#241] and the associated commit. This makes it straightforward for users to trace the change.
|
🤖 Created releases: 🌻 |
🤖 I have created a release beep boop
1.2.0 (2025-04-04)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.
Summary by CodeRabbit
New Features
Bug Fixes
Chores