Skip to content

feat: attempt to gain full release notes posted on mastodon #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025

Conversation

cmeesters
Copy link
Member

@cmeesters cmeesters commented May 16, 2025

This PR should enable the post to mastodon action to publish the part of the Changelog describing the change related to the new version.

Summary by CodeRabbit

  • Chores
    • Improved the format of release announcements on Mastodon, including clearer version information, reordered details, and inline release notes.
    • Updated workflow steps for extracting and posting release notes.
    • Adjusted Mastodon posting action version for workflow stability.

Copy link
Contributor

coderabbitai bot commented May 16, 2025

Walkthrough

The GitHub Actions workflow for announcing releases on Mastodon was updated. A new step was added to extract release notes, the Mastodon posting action version was downgraded, and the announcement message was restructured to improve information order and include extracted release notes inline.

Changes

File(s) Change Summary
.github/workflows/announce-release.yml Added a step to extract release notes, downgraded Mastodon action version, and restructured announcement message formatting.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant Extract Release Notes Action
    participant Mastodon Post Action

    GitHub Actions->>Extract Release Notes Action: Extract release notes from release
    Extract Release Notes Action-->>GitHub Actions: Output extracted notes
    GitHub Actions->>Mastodon Post Action: Post announcement with extracted notes and updated message structure
Loading

Possibly related PRs

Suggested reviewers

  • dlaehnemann

Poem

A rabbit hops through YAML fields,
Extracting notes from code it wields.
Announcements now with structured flair,
Mastodon posts with details to share.
Version steps back, but clarity grows—
In every release, the changelog shows!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/announce-release.yml (2)

18-20: Pin external actions to a specific commit SHA
To prevent unexpected changes when ffurrer2/extract-release-notes@v2 is updated, consider pinning the action to a full commit SHA. For example:

- uses: ffurrer2/extract-release-notes@v2
+ uses: ffurrer2/extract-release-notes@<commit-sha>

41-41: Remove trailing spaces and add newline
YAMLLint reports trailing spaces on this line and a missing end-of-file newline. Cleaning these up will prevent lint errors:

  • Delete any trailing spaces
  • Ensure a single \n at EOF
🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 41-41: no new line character at the end of file

(new-line-at-end-of-file)


[error] 41-41: trailing spaces

(trailing-spaces)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 435e028 and 3adcf39.

📒 Files selected for processing (1)
  • .github/workflows/announce-release.yml (1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/announce-release.yml

[error] 28-28: trailing spaces

(trailing-spaces)


[error] 30-30: trailing spaces

(trailing-spaces)


[error] 32-32: trailing spaces

(trailing-spaces)


[error] 35-35: trailing spaces

(trailing-spaces)


[error] 39-39: trailing spaces

(trailing-spaces)


[error] 41-41: no new line character at the end of file

(new-line-at-end-of-file)


[error] 41-41: trailing spaces

(trailing-spaces)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: testing
🔇 Additional comments (2)
.github/workflows/announce-release.yml (2)

22-22: Reevaluate the downgrade of the Mastodon action
The workflow downgrades snakemake/mastodon-release-post-action from v1.3.0 to v1.2.3. Please document the reason for this change and verify that v1.2.3 still supports all required inputs (e.g., issue_url, templating features).


29-36: ⚠️ Potential issue

Fix undefined placeholders in the announcement message
The placeholder {{ changelog }} isn’t defined by any step, so it will render empty. Instead, reference the extracted notes directly and ensure {{ issue_url }} is provided by the Mastodon action. For example:

-            See {{ changelog }} for details. Here is the header of the changelog:
+            See CHANGELOG.md for full details. Here is the header of the changelog:
 
-            ${{ steps.extract-release-notes.outputs.release_notes }}
+            ${{ steps.extract-release-notes.outputs.release_notes }}

Likely an incorrect or invalid review comment.

🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 30-30: trailing spaces

(trailing-spaces)


[error] 32-32: trailing spaces

(trailing-spaces)


[error] 35-35: trailing spaces

(trailing-spaces)

@cmeesters cmeesters merged commit b207279 into main May 17, 2025
6 checks passed
@cmeesters cmeesters deleted the feat/full_release_notes branch May 17, 2025 14:06
cmeesters pushed a commit that referenced this pull request May 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](v1.2.17...v1.3.0)
(2025-05-17)


### Features

* attempt to gain full release notes posted on mastodon
([#298](#298))
([b207279](b207279))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Documentation**
- Added a new changelog entry for version 1.3.0, highlighting recent
updates.
- **Chores**
  - Updated the package version to 1.3.0.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
cmeesters added a commit that referenced this pull request May 17, 2025
like PR #298 - fix for missing changelog file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant