feat: Add boost fields to space query #823
Conversation
src/graphql/helpers.ts
Outdated
| @@ -83,6 +83,8 @@ export function formatSpace({ | |||
| space.voting.hideAbstain = space.voting.hideAbstain || false; | |||
| space.voteValidation = space.voteValidation || { name: 'any', params: {} }; | |||
| space.delegationPortal = space.delegationPortal || null; | |||
| // disable boost by default until it's enabled | |||
| space.boost = space.boost || { disabled: true, bribeEnabled: false }; | |||
There was a problem hiding this comment.
Would it be more logical to have the field be enabled instead of disabled, so it's more consistent with bribeEnabled ?
There was a problem hiding this comment.
So i talked to @samuveth about it, snapshot-labs/snapshot.js#975 (comment) The future plan is to enable it to everyone by default and only disable it to who want to disable it
There was a problem hiding this comment.
But if we have default values I can also call it enabled, and it could default to true
There was a problem hiding this comment.
But if we have default values I can also call it
enabled, and it could default totrue
I prefer this
|
Can you make the default values both |
|
As I mentioned in DMs I will handle disabling with whitelist now, so it can be |
…into add-boost-fields
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
Fixes #822
Add boost fields to space/spaces query so UI can retrieve them
How to test:
{ space(id:"thanku.eth") { id boost { enabled bribeEnabled } } }