Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed cols property from textarea component #16225

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

marcusmoore
Copy link
Collaborator

Following up on a comment in #16075, this PR simply removes cols from the props on the textarea component. It doesn't actually change anything visually since bootstrap takes over styling so why imply it is supported?

Copy link

what-the-diff bot commented Feb 11, 2025

PR Summary

  • Removal of 'cols' Attribute in Textarea Component
    The attribute that predetermined the breadth of the textarea, 'cols', has been removed. This gives more flexibility in adjusting the size of the textarea to fit different layouts and designs.

  • No Default 'cols' Value
    In addition, the PR includes the removal of a predefined default 'cols' value, which was previously set at 50. This further increases design flexibility. Now, the width of the textarea is no longer limited to a specific value by default.

@snipe snipe merged commit a1b0a30 into snipe:develop Feb 18, 2025
8 of 9 checks passed
@marcusmoore marcusmoore deleted the chore/remove-cols-from-textarea branch February 18, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants