Skip to content

NOSNOW: Fix dotnet formatting #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 20, 2025
Merged

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

Ran dotnet format to clear up the file formatting issues.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner May 19, 2025 06:22
@sfc-gh-snowflakedb-snyk-sa
Copy link
Contributor

sfc-gh-snowflakedb-snyk-sa commented May 19, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 89.06883% with 27 lines in your changes missing coverage. Please review.

Project coverage is 87.69%. Comparing base (b0fd5cb) to head (1ea0e0f).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...lake.Data/Core/FileTransfer/SFFileTransferAgent.cs 50.00% 7 Missing and 3 partials ⚠️
Snowflake.Data/Core/RestResponse.cs 42.85% 4 Missing ⚠️
Snowflake.Data/Core/ReusableChunkParser.cs 95.00% 2 Missing and 1 partial ⚠️
Snowflake.Data/Core/ArrowResultSet.cs 92.85% 2 Missing ⚠️
Snowflake.Data/Core/SFResultSet.cs 66.66% 2 Missing ⚠️
Snowflake.Data/Client/SnowflakeDbTransaction.cs 0.00% 0 Missing and 1 partial ⚠️
...a/Core/Authenticator/Browser/WebListenerStarter.cs 50.00% 1 Missing ⚠️
...ke.Data/Core/Authenticator/KeyPairAuthenticator.cs 0.00% 1 Missing ⚠️
...e.Data/Core/FileTransfer/SFFileCompressionTypes.cs 0.00% 1 Missing ⚠️
Snowflake.Data/Core/SFStatement.cs 0.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1175      +/-   ##
==========================================
- Coverage   87.71%   87.69%   -0.02%     
==========================================
  Files         158      158              
  Lines       13922    13925       +3     
  Branches     1424     1424              
==========================================
+ Hits        12211    12212       +1     
+ Misses       1357     1355       -2     
- Partials      354      358       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pbulawa sfc-gh-pbulawa force-pushed the NOSNOW-fix-dotnet-formatting branch from c28eccf to 63677e7 Compare May 19, 2025 07:27
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 706adfe into master May 20, 2025
65 of 67 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the NOSNOW-fix-dotnet-formatting branch May 20, 2025 08:27
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants