Skip to content

SNOW-2109891 add RepositoryUrl and replace LicenseUrl with LicenseExpression #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

sfc-gh-dszmolka
Copy link
Contributor

Description

SNOW-2109891 - there's a complaint in #1173 that we're missing repository URL in the project, and also using a license URL instead of a license expression.

Apparently, license URL is even deprecated now.

This change attempts to

  • replace PackageLicenseUrl with PackageLicenseExpression
  • add RepositoryUrl and RepositoryType to the project file (reference)

as it's desired and apparently would improve package visibility.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-snowflakedb-snyk-sa
Copy link
Contributor

sfc-gh-snowflakedb-snyk-sa commented May 19, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (b3d99ab) to head (7b62cc0).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1177      +/-   ##
==========================================
+ Coverage   87.68%   87.69%   +0.01%     
==========================================
  Files         158      158              
  Lines       13925    13925              
  Branches     1424     1424              
==========================================
+ Hits        12210    12212       +2     
+ Misses       1360     1355       -5     
- Partials      355      358       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dszmolka sfc-gh-dszmolka marked this pull request as ready for review May 19, 2025 16:15
@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team as a code owner May 19, 2025 16:15
@sfc-gh-dszmolka sfc-gh-dszmolka enabled auto-merge (squash) May 20, 2025 16:28
@sfc-gh-dszmolka sfc-gh-dszmolka merged commit 63ace70 into master May 21, 2025
115 of 118 checks passed
@sfc-gh-dszmolka sfc-gh-dszmolka deleted the SNOW-2109891-add-repourl-licenseexpression branch May 21, 2025 08:55
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants