Skip to content

SNOW-1488703: Add arrow support for structured types #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

SNOW-1488703: Add arrow support for structured types #1178

wants to merge 5 commits into from

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Add arrow support for structured types

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-ext-simba-lf
Add arrow support for structured types
f55ce82
@sfc-gh-ext-simba-lf
Merge branch 'master' of https://github.com/snowflakedb/snowflake-con…
a1750f1 
…nector-net into SNOW-1488703-Arrow-Support-For-Structured-Types

# Conflicts:
#	Snowflake.Data.Tests/IntegrationTests/StructuredArraysIT.cs
#	Snowflake.Data.Tests/IntegrationTests/StructuredMapsIT.cs
#	Snowflake.Data.Tests/IntegrationTests/StructuredObjectsIT.cs
@sfc-gh-ext-simba-lf
Revert commented lines
5499f89
@sfc-gh-ext-simba-lf
Remove bracket
938d36a
@sfc-gh-snowflakedb-snyk-sa
Copy link
Contributor

sfc-gh-snowflakedb-snyk-sa commented May 21, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (a034791) to head (3464096).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1178   +/-   ##
=======================================
  Coverage   87.60%   87.60%           
=======================================
  Files         158      158           
  Lines       13933    13933           
  Branches     1425     1425           
=======================================
  Hits        12206    12206           
  Misses       1370     1370           
  Partials      357      357

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review May 22, 2025 20:27
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner May 22, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-knozderko sfc-gh-knozderko Awaiting requested review from sfc-gh-knozderko

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ext-simba-lf @sfc-gh-snowflakedb-snyk-sa