fix: fall back to license from package if not present in versioned package

[thomasschafer]

As discussed here, ecosyste.ms only returns license info from the versioned endpoint if it is available from the package registry, which it often isn't. We want to fall back to using the package data to retrieve the license if it is not available in the versioned data, which this PR implements.

[mcombuechen]

I think it would be great if we could document this behaviour, because it is not without risk. There might potentially be the occasional case where we fall back on the wrong license information, if the package data differs from that of a versioned package. Is there a good section in the readme where we could add this?

[thomasschafer]

I think it would be great if we could document this behaviour, because it is not without risk. There might potentially be the occasional case where we fall back on the wrong license information, if the package data differs from that of a versioned package. Is there a good section in the readme where we could add this?

Just updated the readme with this info

[mcombuechen]

Ideally—as a test helper—this wouldn't panic. Instead it should require the unmarshal to pass:

Suggested change

	func parseJson(jsonStr string) map[string]any {
	var result map[string]any
	err := json.Unmarshal([]byte(jsonStr), &result)
	if err != nil {
	panic(fmt.Errorf("failed to parse JSON: %w", err))
	}
	return result
	}
	func parseJson(t *testing.T, jsonStr string) map[string]any {
	t.Helper()
	var result map[string]any
	require.NoError(t, json.Unmarshal([]byte(jsonStr), &result))
	return result
	}

[thomasschafer]

Makes sense, done!

[mcombuechen]

Suggested change

	func setupHttpmock(packageVersionsResponse, packageResponse *string) {
	func setupHttpmock(t *testing.T, packageVersionsResponse, packageResponse *string) {
	t.Helper()

[thomasschafer]

Done!