This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Docs - fix bytecode spec #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
reviewed
Sep 25, 2024
| @@ -322,5 +323,6 @@ Verification | |||
| - `hor64` is allowed | |||
| - The offset of jump instructions must be limited to the range of the current function | |||
| - `callx` source register is encoded in the src field | |||
| - The targets of syscalls (`call` instructions with src ≠ 0) must have been registered at verification time | |||
| - The targets of internal calls (`call` instructions with src ≠ 0) must have been registered at verification time | |||
| - The targets of syscalls (`call` instructions with src = 0) must have been registered at verification time | |||
There was a problem hiding this comment.
I know what you meant here, but I think writing prior to verification time would be a clearer wording.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.