Fix bots trying to trade back even when outside scanning range

Author: SpacialCircumstances

server/services/trade.ts

@@ -457,6 +457,14 @@ export default class TradeService extends EventEmitter {
         return tradeTechs;
     }
 
+    _canPlayersTradeInRange(game: Game, fromPlayer: Player, toPlayer: Player) {
+        if (game.settings.player.tradeScanning === 'scanned') {
+            return this.playerService.isInScanningRangeOfPlayer(game, fromPlayer, toPlayer);
+        }
+
+        return true;
+    }
+
     _tradeScanningCheck(game: Game, fromPlayer: Player, toPlayer: Player) {
         if (game.settings.player.tradeScanning === 'scanned') {
             let isInRange = this.playerService.isInScanningRangeOfPlayer(game, fromPlayer, toPlayer);
@@ -525,6 +533,10 @@ export default class TradeService extends EventEmitter {
             return;
         }
 
+        if (!this._canPlayersTradeInRange(game, fromPlayer, toPlayer)) {
+            return;
+        }
+
         let tradeChance = TRADE_CHANCE_BASE + (TRADE_CHANCE_STEP * reputation.score);
         let tradeRoll = this.randomService.getRandomNumber(99);
         let canPerformTrade = tradeRoll <= tradeChance || true;