Fix star/carrier clicking

Author: SpacialCircumstances

client/src/game/animation.ts

@@ -27,7 +27,7 @@ class AnimationService {
       })
     }
 
-    app?.ticker.add(animation)
+    app.ticker.add(animation)
 
     setTimeout(() => {
       container.removeChild(graphics)

client/src/game/map.ts

@@ -13,14 +13,15 @@ import WormHoleLayer from './wormHole'
 import TooltipLayer from './tooltip'
 import type {Store} from "vuex";
 import type {State} from "../store";
-import type {DrawingContext, GameContainer} from "./container";
+import { type DrawingContext, type GameContainer} from "./container";
 import type {Game, Player, Star as StarData, Carrier as CarrierData} from "../types/game";
 import type {Location, MapObject, UserGameSettings} from "@solaris-common";
 import { Chunks } from './chunks'
 import Carrier from "./carrier";
 import type { EventBus } from '../eventBus'
 import MapEventBusEventNames from '../eventBusEventNames/map'
 import MapCommandEventBusEventNames from "../eventBusEventNames/mapCommand";
+import globalGameContainer from './container';
 
 enum Mode {
   Galaxy = 'galaxy',
@@ -286,6 +287,14 @@ export class Map {
     }
   }
 
+  destroy () {
+    if (this.unsubscribe) {
+      this.unsubscribe();
+    }
+
+    this.unsubscribe = undefined;
+  }
+
   setupStar (game: Game, userSettings: UserGameSettings, starData: StarData) {
     let star = this.stars.find(x => x.data._id === starData._id)
 
@@ -791,7 +800,7 @@ export class Map {
     } else if (this.mode === 'ruler') {
       this.rulerPoints!.onStarClicked(e)
     }
-    AnimationService.drawSelectedCircle(this.app, this.container, e.location)
+    AnimationService.drawSelectedCircle(globalGameContainer.app!, this.container, e.location)
   }
 
   onStarDefaultClicked (dic) {
@@ -856,7 +865,7 @@ export class Map {
       this.rulerPoints!.onCarrierClicked(e)
     }
 
-    AnimationService.drawSelectedCircle(this.app, this.container, e.location)
+    AnimationService.drawSelectedCircle(globalGameContainer.app!, this.container, e.location)
   }
 
   onCarrierRightClicked (e) {

client/src/views/game/components/GameContainer.vue

@@ -139,6 +139,8 @@ onMounted(() => {
   });
 
   onBeforeUnmount(() => {
+    gameContainer.destroy();
+
     eventBus.off(MapEventBusEventNames.MapOnStarClicked, onStarClickedHandler);
     eventBus.off(MapEventBusEventNames.MapOnStarRightClicked, onStarRightClickedHandler);
     eventBus.off(MapEventBusEventNames.MapOnCarrierClicked, onCarrierClickedHandler);