Oracle wrapper #49
Oracle wrapper #49
Conversation
| public struct OracleRegistry has key, store { | ||
| id: UID, | ||
| config: OracleRegistryConfig, | ||
| oracles: vector<Oracle>, |
There was a problem hiding this comment.
Why don't we add the Oracle objects as dynamic fields of the oracle registry?
There was a problem hiding this comment.
to save on storage cost? Note that the OracleRegistry is only used as an immutable reference when getting the pyth/switchboard prices, so that's not an issue
| extra_fields: Bag | ||
| } | ||
|
|
||
| public enum OracleType has store, drop, copy { |
There was a problem hiding this comment.
I think we have to test if we can add enum variants accross contract upgrades? if not we might want to use a u8 flag instead
There was a problem hiding this comment.
it's being worked on currently i believe, let me ask. but also, i don't think we are going to add any more oracle types soon
Co-authored-by: 0xLendlord <0xxgen@solend.fi>
Co-authored-by: 0xLendlord <0xxgen@solend.fi>
Co-authored-by: 0xLendlord <0xxgen@solend.fi>
0xripleys
force-pushed
the
oracle_wrapper
branch
from
2857c0b to
97af36f
Compare
|
closing this bc the commit history got messy. squased and rebased everything into the oracle_wrapper_final branch |
No description provided.