feat: submit_answer #266
Merged
feat: submit_answer #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@armaanansari121 is attempting to deploy a commit to the xaxxoo's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Amazing work @armaanansari121, Please check the requested changes and update the tests accordingly. |
manlikeHB
requested changes
Feb 24, 2025
| assert(!round.is_completed, Errors::ROUND_COMPLETED); | ||
|
|
||
| // Get current card index and card | ||
| let current_index = round.next_card_index; |
There was a problem hiding this comment.
After a round is started the next_card fn will be called which will increase the next_card_index by 1, so the current card should be next_card_index - 1.
Suggested change
| let current_index = round.next_card_index; | |
| let current_index = round.next_card_index - 1; |
There was a problem hiding this comment.
Made the changes.
manlikeHB
approved these changes
Feb 25, 2025
|
Thank you @armaanansari121, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
submit_answerfunction.round_idandansweras a parameter and returns a boolean on whether the answer was correct or not.Answerenum to have better readability.submit_answerFunction #193Tests Screenshot