Skip to content

Commit 24dacfc

Browse files
committed
extend and apply the .editorconfig rules
1 parent a040a86 commit 24dacfc

File tree

3 files changed

+139
-7
lines changed

3 files changed

+139
-7
lines changed

.editorconfig

Lines changed: 135 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ root = true
22

33
# All files
44
[*]
5-
indent_size = 2
5+
indent_size = 4
66
indent_style = space
77
insert_final_newline = true
88
trim_trailing_whitespace = true
@@ -17,3 +17,137 @@ end_of_line = crlf
1717
indent_size = 4
1818

1919
dotnet_remove_unnecessary_suppression_exclusions = category: ReSharper
20+
csharp_indent_labels = one_less_than_current
21+
csharp_using_directive_placement = outside_namespace:error
22+
csharp_prefer_simple_using_statement = true:suggestion
23+
csharp_prefer_braces = true:silent
24+
csharp_style_namespace_declarations = file_scoped:error
25+
csharp_style_prefer_method_group_conversion = true:silent
26+
csharp_style_prefer_top_level_statements = true:silent
27+
csharp_style_prefer_primary_constructors = true:suggestion
28+
csharp_prefer_system_threading_lock = true:suggestion
29+
csharp_style_expression_bodied_methods = false:silent
30+
csharp_style_expression_bodied_constructors = false:silent
31+
csharp_style_expression_bodied_operators = false:silent
32+
csharp_style_expression_bodied_properties = true:silent
33+
csharp_style_expression_bodied_indexers = true:silent
34+
csharp_style_expression_bodied_accessors = true:silent
35+
csharp_style_expression_bodied_lambdas = true:silent
36+
csharp_style_expression_bodied_local_functions = false:silent
37+
dotnet_diagnostic.IDE0005.severity = error
38+
csharp_style_throw_expression = true:suggestion
39+
csharp_style_prefer_null_check_over_type_check = true:suggestion
40+
csharp_prefer_simple_default_expression = true:suggestion
41+
csharp_style_prefer_local_over_anonymous_function = true:suggestion
42+
csharp_style_prefer_index_operator = true:suggestion
43+
csharp_style_prefer_range_operator = true:suggestion
44+
csharp_style_implicit_object_creation_when_type_is_apparent = true:suggestion
45+
csharp_style_prefer_tuple_swap = true:suggestion
46+
csharp_style_prefer_utf8_string_literals = true:suggestion
47+
csharp_style_inlined_variable_declaration = true:suggestion
48+
csharp_style_deconstructed_variable_declaration = true:suggestion
49+
csharp_style_unused_value_assignment_preference = discard_variable:suggestion
50+
csharp_style_unused_value_expression_statement_preference = discard_variable:silent
51+
csharp_prefer_static_local_function = true:suggestion
52+
csharp_prefer_static_anonymous_function = true:suggestion
53+
csharp_style_prefer_readonly_struct = true:suggestion
54+
csharp_style_prefer_readonly_struct_member = true:suggestion
55+
csharp_style_allow_embedded_statements_on_same_line_experimental = true:silent
56+
csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true:silent
57+
csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = true:silent
58+
csharp_style_allow_blank_line_after_token_in_conditional_expression_experimental = true:silent
59+
csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental = true:silent
60+
csharp_style_conditional_delegate_call = true:suggestion
61+
csharp_style_prefer_switch_expression = true:suggestion
62+
csharp_style_prefer_pattern_matching = true:silent
63+
csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
64+
csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
65+
csharp_style_prefer_not_pattern = true:suggestion
66+
csharp_style_prefer_extended_property_pattern = true:suggestion
67+
csharp_style_var_for_built_in_types = false:silent
68+
csharp_style_var_when_type_is_apparent = false:silent
69+
csharp_style_var_elsewhere = false:silent
70+
csharp_space_around_binary_operators = before_and_after
71+
72+
73+
[*.{cs,vb}]
74+
#### Naming styles ####
75+
76+
# Naming rules
77+
78+
dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
79+
dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
80+
dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
81+
82+
dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
83+
dotnet_naming_rule.types_should_be_pascal_case.symbols = types
84+
dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
85+
86+
dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
87+
dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
88+
dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
89+
90+
# Symbol specifications
91+
92+
dotnet_naming_symbols.interface.applicable_kinds = interface
93+
dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
94+
dotnet_naming_symbols.interface.required_modifiers =
95+
96+
dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
97+
dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
98+
dotnet_naming_symbols.types.required_modifiers =
99+
100+
dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
101+
dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
102+
dotnet_naming_symbols.non_field_members.required_modifiers =
103+
104+
# Naming styles
105+
106+
dotnet_naming_style.begins_with_i.required_prefix = I
107+
dotnet_naming_style.begins_with_i.required_suffix =
108+
dotnet_naming_style.begins_with_i.word_separator =
109+
dotnet_naming_style.begins_with_i.capitalization = pascal_case
110+
111+
dotnet_naming_style.pascal_case.required_prefix =
112+
dotnet_naming_style.pascal_case.required_suffix =
113+
dotnet_naming_style.pascal_case.word_separator =
114+
dotnet_naming_style.pascal_case.capitalization = pascal_case
115+
116+
dotnet_naming_style.pascal_case.required_prefix =
117+
dotnet_naming_style.pascal_case.required_suffix =
118+
dotnet_naming_style.pascal_case.word_separator =
119+
dotnet_naming_style.pascal_case.capitalization = pascal_case
120+
dotnet_style_operator_placement_when_wrapping = beginning_of_line
121+
tab_width = 4
122+
end_of_line = crlf
123+
dotnet_style_coalesce_expression = true:suggestion
124+
dotnet_style_null_propagation = true:suggestion
125+
dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
126+
dotnet_style_prefer_auto_properties = true:silent
127+
dotnet_style_object_initializer = true:suggestion
128+
dotnet_style_collection_initializer = true:suggestion
129+
dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
130+
dotnet_style_prefer_conditional_expression_over_assignment = true:silent
131+
dotnet_style_prefer_conditional_expression_over_return = true:silent
132+
dotnet_style_explicit_tuple_names = true:suggestion
133+
dotnet_style_prefer_inferred_tuple_names = true:suggestion
134+
dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
135+
dotnet_style_prefer_compound_assignment = true:suggestion
136+
dotnet_style_prefer_simplified_interpolation = true:suggestion
137+
dotnet_style_prefer_collection_expression = when_types_loosely_match:suggestion
138+
dotnet_style_namespace_match_folder = true:suggestion
139+
dotnet_style_readonly_field = true:suggestion
140+
dotnet_style_predefined_type_for_locals_parameters_members = true:silent
141+
dotnet_style_predefined_type_for_member_access = true:silent
142+
dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent
143+
dotnet_style_allow_multiple_blank_lines_experimental = true:silent
144+
dotnet_style_allow_statement_immediately_after_block_experimental = true:silent
145+
dotnet_code_quality_unused_parameters = all:suggestion
146+
dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent
147+
dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent
148+
dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent
149+
dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent
150+
dotnet_style_qualification_for_field = false:silent
151+
dotnet_style_qualification_for_property = false:silent
152+
dotnet_style_qualification_for_method = false:silent
153+
dotnet_style_qualification_for_event = false:silent

src/Sotsera.Sources.Common/Extensions/StringExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ public static string JoinStrings(this IEnumerable<string?>? values, string? sepa
2222
? string.Empty
2323
: string.Join(separator, values.Where(x => includeEmptyValues || !string.IsNullOrWhiteSpace(x)));
2424
}
25-
}
25+
}

test/Sotsera.Sources.Common.Tests.Unit/Extensions/StringExtensionsTests.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
1-
using System.Collections.ObjectModel;
2-
using System.Diagnostics.CodeAnalysis;
1+
using System.Diagnostics.CodeAnalysis;
32
using Sotsera.Sources.Common.Extensions;
43
using Xunit.Abstractions;
5-
using static System.Runtime.InteropServices.JavaScript.JSType;
64

75
namespace Sotsera.Sources.Common.Tests.Unit.Extensions;
86

@@ -110,7 +108,7 @@ public StringEnumerableToBeJoinedValueGenerator()
110108
}
111109
}
112110

113-
public class EnumerableStringList: IXunitSerializable
111+
public class EnumerableStringList : IXunitSerializable
114112
{
115113
public IEnumerable<string?>? Values { get; private init; }
116114

@@ -123,7 +121,7 @@ public EnumerableStringList(IEnumerable<string?>? values)
123121
public EnumerableStringList()
124122
{
125123
}
126-
124+
127125
public void Deserialize(IXunitSerializationInfo info)
128126
{
129127
info.GetValue<IEnumerable<string?>?>(nameof(Values));

0 commit comments

Comments
 (0)