Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

fix/graphql/database: fix repo permission sync count to ignore soft deleted repositories #63298

Conversation

ggilmore
Copy link
Contributor

@ggilmore ggilmore commented Jun 17, 2024

This PR changes the query that powers the "failed repository sync count" on the permissions center to now properly ignore soft-deleted repositories. The admin can't take any action to remedy this, so there is no point in displaying it.

Screenshot 2024-06-17 at 12.55.19 PM.png

Test plan

Unit tests

Changelog

  • The failed repository permission sync count on the permission dashboard now properly ignores syncs from deleted repository (which is the expected behavior).

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2024
@github-actions github-actions bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Jun 17, 2024
@ggilmore ggilmore force-pushed the 06-14-fix_graphql_database_make_count_of_failed_user_permissions_syncs_ignore_soft_deleted_users branch from 1ea3cc5 to fe5c54d Compare June 17, 2024 19:49
@ggilmore ggilmore force-pushed the 06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories branch from d4a0c3b to 8b8b223 Compare June 17, 2024 19:49
@ggilmore ggilmore requested a review from a team June 17, 2024 19:54
@ggilmore ggilmore marked this pull request as ready for review June 17, 2024 19:56
Copy link

graphite-app bot commented Jun 17, 2024

Cartoon gif. An awestruck young Carl Fredricksen from Up wears an aviator cap while watching a movie in a theater. He pulls goggles over his eyes, and gives a smiling thumbs-up to the screen. (Added via Giphy)

@ggilmore ggilmore force-pushed the 06-14-fix_graphql_database_make_count_of_failed_user_permissions_syncs_ignore_soft_deleted_users branch from fe5c54d to 0a4ff76 Compare June 17, 2024 20:19
@ggilmore ggilmore force-pushed the 06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories branch from 8b8b223 to e06238d Compare June 17, 2024 20:19
@ggilmore ggilmore changed the base branch from 06-14-fix_graphql_database_make_count_of_failed_user_permissions_syncs_ignore_soft_deleted_users to graphite-base/63298 June 17, 2024 20:27
@ggilmore ggilmore changed the base branch from graphite-base/63298 to main June 17, 2024 20:27
@ggilmore ggilmore force-pushed the 06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories branch from e06238d to cee1f50 Compare June 17, 2024 20:27
@ggilmore ggilmore merged commit 6607988 into main Jun 17, 2024
13 of 14 checks passed
@ggilmore ggilmore deleted the 06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories branch June 17, 2024 20:35
Copy link
Contributor Author

Merge activity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants