This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feature/internal/database: add test to ensure that not found errors fulfiill errcode.NotFound #63299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/product-platform
team/source
ggilmore
force-pushed
the
06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories
branch
from
d4a0c3b to
8b8b223
Compare
ggilmore
force-pushed
the
graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound
branch
from
4d5e82c to
c3c0cf5
Compare
|
|
ggilmore
force-pushed
the
06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories
branch
from
8b8b223 to
e06238d
Compare
ggilmore
force-pushed
the
graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound
branch
from
c3c0cf5 to
fd80f0c
Compare
ggilmore
force-pushed
the
06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories
branch
from
e06238d to
cee1f50
Compare
ggilmore
force-pushed
the
graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound
branch
from
fd80f0c to
68da82c
Compare
ggilmore
changed the base branch from
06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories
to
graphite-base/63299
…ulfiill errcode.NotFound
ggilmore
force-pushed
the
graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound
branch
from
68da82c to
b7026c4
Compare
ggilmore
deleted the
graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change that ensures that the user/repository not found error types fulfill the errcode.NotFound interface. This is a building block for https://app.graphite.dev//github/pr/sourcegraph/sourcegraph/63302
Test plan
Unit tests
Changelog