Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix #104

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Minor fix #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b99858
support changing n_fft
takenori-y Oct 28, 2024
c2eac8a
check pytorch 2.5
takenori-y Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
torch: 2.0.0
torchaudio: 2.0.1
- python: 3.12
torch: 2.4.1
torchaudio: 2.4.1
torch: 2.5.0
torchaudio: 2.5.0

steps:
- name: Clone
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
[![Stable Manual](https://img.shields.io/badge/docs-stable-blue.svg)](https://sp-nitech.github.io/diffsptk/2.2.0/)
[![Downloads](https://static.pepy.tech/badge/diffsptk)](https://pepy.tech/project/diffsptk)
[![Python Version](https://img.shields.io/pypi/pyversions/diffsptk.svg)](https://pypi.python.org/pypi/diffsptk)
[![PyTorch Version](https://img.shields.io/badge/pytorch-2.0.0%20%7C%202.4.1-orange.svg)](https://pypi.python.org/pypi/diffsptk)
[![PyTorch Version](https://img.shields.io/badge/pytorch-2.0.0%20%7C%202.5.0-orange.svg)](https://pypi.python.org/pypi/diffsptk)
[![PyPI Version](https://img.shields.io/pypi/v/diffsptk.svg)](https://pypi.python.org/pypi/diffsptk)
[![Codecov](https://codecov.io/gh/sp-nitech/diffsptk/branch/master/graph/badge.svg)](https://app.codecov.io/gh/sp-nitech/diffsptk)
[![License](https://img.shields.io/github/license/sp-nitech/diffsptk.svg)](https://github.com/sp-nitech/diffsptk/blob/master/LICENSE)
Expand Down
9 changes: 6 additions & 3 deletions diffsptk/modules/mglsadf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ class PseudoMGLSADigitalFilter(nn.Module):
the impulse response converted from input mel-cepstral coefficients using FFT.
'freq-domain' performs filtering in the frequency domain rather than time one.

n_fft : int >= 1
Number of FFT bins used for conversion. Higher values result in increased
conversion accuracy.

taylor_order : int >= 0
Order of Taylor series expansion (valid only if **mode** is 'multi-stage').

Expand All @@ -97,9 +101,6 @@ class PseudoMGLSADigitalFilter(nn.Module):
ir_length : int >= 1
Length of impulse response (valid only if **mode** is 'single-stage').

n_fft : int >= 1
Number of FFT bins for conversion (valid only if **mode** is 'single-stage').

**kwargs : additional keyword arguments
See :func:`~diffsptk.ShortTimeFourierTransform` (valid only if **mode** is
'freq-domain').
Expand Down Expand Up @@ -213,6 +214,7 @@ def __init__(
phase="minimum",
taylor_order=20,
cep_order=199,
n_fft=512,
):
super().__init__()

Expand All @@ -239,6 +241,7 @@ def __init__(
cep_order,
in_alpha=alpha,
in_gamma=gamma,
n_fft=n_fft,
)
self.linear_intpl = LinearInterpolation(frame_period)

Expand Down