Skip to content

feat(sol): sign gadget #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

feat(sol): sign gadget #860

merged 2 commits into from
Jun 4, 2025

Conversation

stuarttimwhite
Copy link
Contributor

@stuarttimwhite stuarttimwhite commented May 22, 2025

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

We need sign_expr for group by

What changes are included in this PR?

New sign_expr in solidity.

Are these changes tested?

Yes

@stuarttimwhite stuarttimwhite force-pushed the feat(sol)/sign-gadget branch from f1aea19 to b273aeb Compare May 22, 2025 21:00
@stuarttimwhite stuarttimwhite marked this pull request as ready for review May 22, 2025 21:09
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (95439e3) to head (31acbc4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
- Coverage   96.71%   96.71%   -0.01%     
==========================================
  Files         332      332              
  Lines       60150    60125      -25     
==========================================
- Hits        58176    58149      -27     
- Misses       1974     1976       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stuarttimwhite stuarttimwhite force-pushed the feat(sol)/sign-gadget branch 9 times, most recently from 9002c4c to 793343f Compare May 30, 2025 16:33
@stuarttimwhite stuarttimwhite force-pushed the feat(sol)/sign-gadget branch 4 times, most recently from 012a2ab to 79139bb Compare June 4, 2025 04:48
@iajoiner iajoiner enabled auto-merge (squash) June 4, 2025 21:47
@iajoiner iajoiner force-pushed the feat(sol)/sign-gadget branch from 79139bb to 31acbc4 Compare June 4, 2025 21:47
@iajoiner iajoiner merged commit e088a27 into main Jun 4, 2025
14 checks passed
@stuarttimwhite stuarttimwhite deleted the feat(sol)/sign-gadget branch June 5, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants