Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix nix flake #3259

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

meenzen
Copy link
Contributor

@meenzen meenzen commented Apr 6, 2024

  • The flake.lock file should be committed to the repo
  • nix-direnv creates the .direnv directory so we need to ignore it

@altsalt
Copy link
Contributor

altsalt commented Apr 7, 2024

Please see the conversation related to this closed PR.

@meenzen meenzen force-pushed the chore/fix-nix-flake branch from 3a59bc3 to a52dfa0 Compare April 8, 2024 12:22
@meenzen
Copy link
Contributor Author

meenzen commented Apr 8, 2024

I have now also adressed most of the comments of #2646

@spantaleev spantaleev merged commit 0afc4f1 into spantaleev:master Apr 9, 2024
2 checks passed
@spantaleev
Copy link
Owner

I don't know much about Nix to comment on this properly, but it seams reasonable. Merged! Thank you!

@meenzen meenzen deleted the chore/fix-nix-flake branch April 9, 2024 07:47
venimus pushed a commit to superhero-com/matrix-docker-ansible-deploy that referenced this pull request May 21, 2024
Chasethechicken pushed a commit to Chasethechicken/matrix-docker-ansible-deploy that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants