Lazy parse the header comments into string

Author: furuame

lib/stf_reader.cpp

@@ -42,7 +42,6 @@ namespace stf {
                 switch(rec->getId()) {
                     case descriptors::internal::Descriptor::STF_COMMENT:
                         header_comments_.emplace_back(STFRecord::grabOwnership<CommentRecord>(rec));
-                        header_comments_str_.emplace_back(header_comments_.back()->getData());
                         break;
                     case descriptors::internal::Descriptor::STF_ISA:
                         stf_assert(!isa_, "Header has multiple ISA records");

lib/stf_reader_base.cpp

@@ -76,6 +76,15 @@ namespace stf {
         return *trace_info_records_.back();
     }
 
+    const std::vector<std::string>& STFReaderBase::getHeaderCommentsString() {
+        if(!header_comments_.empty() && header_comments_str_.empty()) {
+            for(const auto& c : header_comments_) {
+                header_comments_str_.emplace_back(c->getData());
+            }
+        }
+        return header_comments_str_;
+    }
+
     int STFReaderBase::close() {
         version_.reset();
         header_comments_.clear();

stf-inc/stf_reader_base.hpp

@@ -136,9 +136,10 @@ namespace stf {
                 return header_comments_;
              }
 
-            inline const std::vector<std::string>& getHeaderCommentsString() const {
-                return header_comments_str_;
-            }
+            /**
+             * Gets the header comments in vector type of std::string
+             */
+            const std::vector<std::string>& getHeaderCommentsString();
 
             /**
              * Returns the number of records read so far