Skip to content

Commit d38e9ba

Browse files
authored
Merge pull request #11 from spherical-go/develop
fix index page broken bug within list_games
2 parents 6172218 + 8ed111d commit d38e9ba

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

polyclash/util/storage.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,11 @@ def get_plays(self, game_id):
276276
return []
277277

278278
def list_rooms(self):
279-
return self.redis.lrange('games', 0, -1)
279+
if not self.redis.exists('games'):
280+
return []
281+
return list([
282+
item.decode('utf-8') for item in self.redis.lrange('games', 0, -1)
283+
])
280284

281285
def close_room(self, game_id):
282286
pass

tests/test_server.py

+4
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ def storage():
2626
return server.storage
2727

2828

29+
def test_index_page(storage, test_client):
30+
result = test_client.get('/sphgo/')
31+
assert result.status_code == 200
32+
assert b'PolyClash' in result.data
2933

3034

3135
def test_new_game(storage, test_client, socketio_client):

tests/test_storage.py

+6
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,12 @@ def storage():
2929
return server.storage
3030

3131

32+
def test_index_page(storage, test_client):
33+
result = test_client.get('/sphgo/')
34+
assert result.status_code == 200
35+
assert b'PolyClash' in result.data
36+
37+
3238
def test_new_game(storage, test_client, socketio_client):
3339
result = test_client.post('/sphgo/new', json={'key': server_token})
3440
assert result.status_code == 200

0 commit comments

Comments
 (0)