Skip to content

Fix suppressed default visible #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

michele-riva
Copy link

For some parser arguments (e.g., action='version'), the "==SUPPRESSED==" default would be unexpectedly shown.

Added also regression test.

@michele-riva
Copy link
Author

Failure in py3.7 is out of my control. Seems to be due to an argument-less @functools.lru_cache decoration, which is only supported starting from Python 3.8. A search for lru_cache brought up the following potentially problematic modules, involved during testing:

  • PIL.ImageMode.py L42
  • packaging._manylinux.py L172 (this is the one that causes the build error)
  • packaging._musllinux.py L33

@michele-riva
Copy link
Author

michele-riva commented Jun 13, 2024

I guess the 3.7 build requires some more specification in poetry.lock, as it seems that poetry is installing a version of packaging that is incompatible with Python 3.7. I'm not familiar enough with poetry to do anything about this myself, though.

@ashb
Copy link
Collaborator

ashb commented Jun 14, 2024

I should remove 3.7 from the supported versions now I think as it's end-of-lifed.

@michele-riva
Copy link
Author

I should remove 3.7 from the supported versions now I think as it's end-of-lifed.

Works for me. Would you like to do it in a separate PR?

@michele-riva
Copy link
Author

@ashb, let me know if I should do anything about the py3.7 support, either here or in a separate PR. It would be nice if I could tick this PR off my TODO list.

michele-riva and others added 5 commits July 15, 2024 16:39
Bug was likely because of the comparison with '==SUPPRESS==' rather than "'==SUPPRESS=='", but having a dedicated function helps readability.
Adjust AssertionError message depending on whether the xpath  check intended to find or not a certain string.

Previous version would give unexpected messages when one would want to make sure that a certain name was not found in HTML nodes.
@AA-Turner AA-Turner force-pushed the fix-suppressed-visible branch from b082da5 to 99b2ad3 Compare July 15, 2024 15:43
@AA-Turner AA-Turner merged commit c8beb8f into sphinx-doc:main Jul 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants