Skip to content

Tests: update LaTeX label test expectations from docutils r10151 #13610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jayaddison
Copy link
Contributor

Purpose

Resolves a unit test failure in the test_latex_labels test case after upgrading to docutils r10151 or greater.

References

cc @jfbu

@jayaddison jayaddison changed the title tests: update LaTeX label test expectations from docutils r10151 Tests: update LaTeX label test expectations from docutils r10151 Jun 2, 2025
@AA-Turner AA-Turner merged commit 68d5610 into sphinx-doc:master Jun 2, 2025
25 checks passed
@jayaddison jayaddison deleted the issue-13609/resolve-docutils-r10151-compatibility branch June 2, 2025 22:29
jfbu added a commit to jfbu/sphinx that referenced this pull request Jun 5, 2025
Refs: sphinx-doc#13609, sphinx-doc#11093 (sphinx-doc#11333), sphinx-doc#6026 (sphinx-doc#6051).

- Fix misnomer in test-latex-labels/index.rst text.

  Refs:
  sphinx-doc#13609 (comment)

- Patch writers/latex.py as per the proposal at end of:
  sphinx-doc#13609 (comment)

- Update test_latex_build.py::test_latex_labels to detect non
  desired extra label in LaTeX output.

Nota bene: this commit does not revert "Tests: update LaTeX label
test expectations from Docutils r10151 (sphinx-doc#13610)" (commit
68d5610) as it is still
necessary for compatibility with both Docutils 0.21.2 and
Docutils HEAD at their r10151.
jfbu added a commit to jfbu/sphinx that referenced this pull request Jun 12, 2025
Refs: sphinx-doc#13609, sphinx-doc#11093 (sphinx-doc#11333), sphinx-doc#6026 (sphinx-doc#6051).

- Fix misnomer in test-latex-labels/index.rst text.

  Refs:
  sphinx-doc#13609 (comment)

- Patch writers/latex.py as per the proposal at end of:
  sphinx-doc#13609 (comment)

- Update test_latex_build.py::test_latex_labels to detect non
  desired extra label in LaTeX output.

Nota bene: this commit does not revert "Tests: update LaTeX label
test expectations from Docutils r10151 (sphinx-doc#13610)" (commit
68d5610) as it is still
necessary for compatibility with both Docutils 0.21.2 and
Docutils HEAD at their r10151.

Rebased on e1bd9cb with resolved Conflicts:
	sphinx/writers/latex.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: change-in-output with docutils r10151 (0.22-rc)
2 participants