Skip to content

Commit 6db225b

Browse files
committed
Revert relative url behaviour
1 parent 8ee2ff6 commit 6db225b

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

sphinxext/opengraph/__init__.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,6 @@ def get_tags(
114114
ogp_use_first_image = config["ogp_use_first_image"]
115115
ogp_image_alt = fields.get("og:image:alt", config["ogp_image_alt"])
116116

117-
if image_url:
118-
image_url_parsed = urlparse(image_url)
119-
if not image_url_parsed.scheme:
120-
# Relative image path detected. Make absolute.
121-
image_url = urljoin(config["ogp_site_url"], image_url_parsed.path)
122-
123117
fields.pop("og:image:alt", None)
124118

125119
if ogp_use_first_image:
@@ -132,6 +126,11 @@ def get_tags(
132126
ogp_image_alt = first_image.get("alt", None)
133127

134128
if image_url:
129+
if image_url:
130+
image_url_parsed = urlparse(image_url)
131+
if not image_url_parsed.scheme:
132+
# Relative image path detected. Make absolute.
133+
image_url = urljoin(config["ogp_site_url"], image_url_parsed.path)
135134
tags["og:image"] = image_url
136135

137136
# Add image alt text (either provided by config or from site_name)

0 commit comments

Comments
 (0)