Skip adding namespace suffix to VirtualService if it already exists (#45)

Co-authored-by: Harsimran Singh Maan <maan.harry@gmail.com>

Author: sbernauer

Diff for: proxy/create.go

@@ -43,7 +43,14 @@ func (i *IstioClient) createVirtualService(r route) error {
 		return err
 	}
 	destinationHost, destinationPort := r.splitTarget()
-	destinationHost = fmt.Sprintf("%s.%s.svc.%s", destinationHost, i.namespace, i.clusterDomain)
+
+	// If the destinationHost already has its complete fqdn we don't need to append namespace of the hub, service and cluster domain again.
+	// This could be the case if the notebook pod is running in an other namespace than the hub pod
+	// and c.KubeSpawner.pod_connect_ip needs to be set to something like "jupyter-{username}.<target-namespace-of-notebook>.svc.cluster.local"
+	if !strings.HasSuffix(destinationHost, fmt.Sprintf(".svc.%s", i.clusterDomain)) {
+		destinationHost = fmt.Sprintf("%s.%s.svc.%s", destinationHost, i.namespace, i.clusterDomain)
+	}
+
 	vsName := i.virtualServiceNameWithPrefix(r.RouteSpec)
 	vs := virtualService(vsName, i.gateway, i.host, destinationHost, destinationPort, r.RouteSpec, annotations)