-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX/#184] 네비게이션 팝스택 설정 추가 #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 한번 확인해보시고 같이 확인해봐요!
@@ -111,7 +111,7 @@ fun MainScreen( | |||
|
|||
registerNavGraph( | |||
paddingValues = paddingValues, | |||
navigateToExplore = navigator::navigateToExplore | |||
navigateToExplore = { navigator.navigateToExplore(fromRegister = true) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
navigateToExplore = { navigator.navigateToExplore(fromRegister = true) } | |
navigateToExplore = { navigator.navigate(MainTab.EXPLORE) } |
P1: 이렇게 수정하고 navigateToExplore 함수를 변경하지 않는건 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀🚀🚀🚀🚀🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related issue 🛠
Work Description ✏️