Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/#184] 네비게이션 팝스택 설정 추가 #185

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

angryPodo
Copy link
Collaborator

Related issue 🛠

Work Description ✏️

  • 등록 완료 후 탐색 뷰에서 백버튼시 등록으로 돌아가는 이슈 해결

@angryPodo angryPodo added 💙민재💙 💙민재💙 FEAT✨ 새로운 기능 구현 labels Jan 24, 2025
@angryPodo angryPodo self-assigned this Jan 24, 2025
@angryPodo angryPodo requested a review from a team as a code owner January 24, 2025 06:38
@angryPodo angryPodo linked an issue Jan 24, 2025 that may be closed by this pull request
Copy link
Member

@Roel4990 Roel4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 한번 확인해보시고 같이 확인해봐요!

@@ -111,7 +111,7 @@ fun MainScreen(

registerNavGraph(
paddingValues = paddingValues,
navigateToExplore = navigator::navigateToExplore
navigateToExplore = { navigator.navigateToExplore(fromRegister = true) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
navigateToExplore = { navigator.navigateToExplore(fromRegister = true) }
navigateToExplore = { navigator.navigate(MainTab.EXPLORE) }

P1: 이렇게 수정하고 navigateToExplore 함수를 변경하지 않는건 어떨까요?

@angryPodo angryPodo added FIX🔨 버그 및 오류 해결 and removed FEAT✨ 새로운 기능 구현 labels Jan 24, 2025
Copy link
Member

@Roel4990 Roel4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

Copy link
Collaborator

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀🚀🚀🚀🚀🚀

Copy link
Collaborator

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angryPodo angryPodo merged commit 0027fb5 into develop Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIX🔨 버그 및 오류 해결 💙민재💙 💙민재💙
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] register to explore 스택 관리 수정
4 participants