[MOD/#203] 최근 검색어 중복을 제거 하도록 수정합니다 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyobeen-Park
approved these changes
Feb 20, 2025
| @Query("DELETE FROM search WHERE id = :id") | ||
| suspend fun deleteSearchById(id: Int) | ||
| // 검색어가 6개 이상인 경우 가장 오래된 검색어 삭제 | ||
| if (getSearchCount() >= 6) { |
There was a problem hiding this comment.
P4: 6도 상수로 빼주면 좋을 것 같아요!!
There was a problem hiding this comment.
인정~ 뺄까말까했는데 빼도록 하겠습니다~
chattymin
approved these changes
Feb 20, 2025
Comment on lines
+45
to
+46
| // 빈 문자열이나 공백만 있는 경우 저장하지 않음 | ||
| if (trimmedText.isBlank()) return |
|
근데 갑자기 궁금한건데 쟤 왜저렇게 넓음? |
제가 가진 유일한 안드로이드패드로 녹화했숩니다ㅠ 하지만 대응 잘되죠?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
recent_search.mp4
To Reviewers 📢
오랜만에 쿼리할라니까 머리가 말랑말랑