fix unit test

Jamie Wiebe · Jamie Wiebe · commit 7ea8002b202a · 2022-11-23T10:09:17.000+01:00
diff --git a/operator/redisfailover/service/generator_test.go b/operator/redisfailover/service/generator_test.go
@@ -1488,7 +1488,6 @@ func TestSentinelImagePullPolicy(t *testing.T) {
 }
 
 func TestRedisExtraVolumeMounts(t *testing.T) {
-
 	mode := int32(755)
 	tests := []struct {
 		name                 string
@@ -1564,7 +1563,6 @@ func TestRedisExtraVolumeMounts(t *testing.T) {
 }
 
 func TestSentinelExtraVolumeMounts(t *testing.T) {
-
 	mode := int32(755)
 	tests := []struct {
 		name                 string
@@ -1640,7 +1638,6 @@ func TestSentinelExtraVolumeMounts(t *testing.T) {
 }
 
 func TestCustomPort(t *testing.T) {
-
 	default_port := int32(6379)
 	custom_port := int32(12345)
 	tests := []struct {
@@ -1696,7 +1693,6 @@ func TestCustomPort(t *testing.T) {
 }
 
 func TestRedisEnv(t *testing.T) {
-
 	default_port := int32(6379)
 	tests := []struct {
 		name             string
@@ -1709,7 +1705,7 @@ func TestRedisEnv(t *testing.T) {
 			expectedRedisEnv: []corev1.EnvVar{
 				{
 					Name:  "REDIS_ADDR",
-					Value: fmt.Sprintf("redis://localhost:%[1]v", default_port),
+					Value: fmt.Sprintf("redis://127.0.0.1:%[1]v", default_port),
 				},
 				{
 					Name:  "REDIS_PORT",
@@ -1727,7 +1723,7 @@ func TestRedisEnv(t *testing.T) {
 			expectedRedisEnv: []corev1.EnvVar{
 				{
 					Name:  "REDIS_ADDR",
-					Value: fmt.Sprintf("redis://localhost:%[1]v", default_port),
+					Value: fmt.Sprintf("redis://127.0.0.1:%[1]v", default_port),
 				},
 				{
 					Name:  "REDIS_PORT",

Original file line number	Diff line number	Diff line change
`@@ -1488,7 +1488,6 @@ func TestSentinelImagePullPolicy(t *testing.T) {`
`1488`	`1488`	`}`
`1489`	`1489`
`1490`	`1490`	`func TestRedisExtraVolumeMounts(t *testing.T) {`
`1491`		`-`
`1492`	`1491`	`mode := int32(755)`
`1493`	`1492`	`tests := []struct {`
`1494`	`1493`	`name string`
`@@ -1564,7 +1563,6 @@ func TestRedisExtraVolumeMounts(t *testing.T) {`
`1564`	`1563`	`}`
`1565`	`1564`
`1566`	`1565`	`func TestSentinelExtraVolumeMounts(t *testing.T) {`
`1567`		`-`
`1568`	`1566`	`mode := int32(755)`
`1569`	`1567`	`tests := []struct {`
`1570`	`1568`	`name string`
`@@ -1640,7 +1638,6 @@ func TestSentinelExtraVolumeMounts(t *testing.T) {`
`1640`	`1638`	`}`
`1641`	`1639`
`1642`	`1640`	`func TestCustomPort(t *testing.T) {`
`1643`		`-`
`1644`	`1641`	`default_port := int32(6379)`
`1645`	`1642`	`custom_port := int32(12345)`
`1646`	`1643`	`tests := []struct {`
`@@ -1696,7 +1693,6 @@ func TestCustomPort(t *testing.T) {`
`1696`	`1693`	`}`
`1697`	`1694`
`1698`	`1695`	`func TestRedisEnv(t *testing.T) {`
`1699`		`-`
`1700`	`1696`	`default_port := int32(6379)`
`1701`	`1697`	`tests := []struct {`
`1702`	`1698`	`name string`
`@@ -1709,7 +1705,7 @@ func TestRedisEnv(t *testing.T) {`
`1709`	`1705`	`expectedRedisEnv: []corev1.EnvVar{`
`1710`	`1706`	`{`
`1711`	`1707`	`Name: "REDIS_ADDR",`
`1712`		`- Value: fmt.Sprintf("redis://localhost:%[1]v", default_port),`
	`1708`	`+ Value: fmt.Sprintf("redis://127.0.0.1:%[1]v", default_port),`
`1713`	`1709`	`},`
`1714`	`1710`	`{`
`1715`	`1711`	`Name: "REDIS_PORT",`
`@@ -1727,7 +1723,7 @@ func TestRedisEnv(t *testing.T) {`
`1727`	`1723`	`expectedRedisEnv: []corev1.EnvVar{`
`1728`	`1724`	`{`
`1729`	`1725`	`Name: "REDIS_ADDR",`
`1730`		`- Value: fmt.Sprintf("redis://localhost:%[1]v", default_port),`
	`1726`	`+ Value: fmt.Sprintf("redis://127.0.0.1:%[1]v", default_port),`
`1731`	`1727`	`},`
`1732`	`1728`	`{`
`1733`	`1729`	`Name: "REDIS_PORT",`