Bump org.apache.pdfbox to 3.0.4 and guard against empty unicode strings #3271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Frizelle <david.frizelle@gmail.com>
Signed-off-by: David Frizelle <david.frizelle@gmail.com>
dafriz
changed the title
|
Note that the update to PDF Box 3.0.4 also needs the guard against empty unicode strings change otherwise the existing test case fails. |
| @@ -280,7 +280,7 @@ | |||
| <protobuf-java.version>3.25.2</protobuf-java.version> | |||
|
|
|||
| <!-- readers/writer/stores dependencies--> | |||
| <pdfbox.version>3.0.3</pdfbox.version> | |||
| <pdfbox.version>3.0.4</pdfbox.version> | |||
There was a problem hiding this comment.
Is it worth trying to go to 3.0.5?
There was a problem hiding this comment.
3.0.4 resolves the current maven convergence issue.
Tika 3.2.0 is due any day now which uses 3.0.5 so would reccomend waiting a while and then updating them both together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dependency convergence error with tika version of pdfbox
Fixes 3265
Guards against empty unicode strings
Fixes 3054