Skip to content

spring-ai-retry should not require spring-webflux dependency #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pkubowicz opened this issue May 23, 2025 · 0 comments · May be fixed by #3308
Open

spring-ai-retry should not require spring-webflux dependency #3307

pkubowicz opened this issue May 23, 2025 · 0 comments · May be fixed by #3308

Comments

@pkubowicz
Copy link

pkubowicz commented May 23, 2025 •
edited
Loading

Bug description
spring-ai-retry/pom.xml contains spring-webflux. This is an invasive library (conflicts with spring-webmvc) and should not be added as a dependency without a good reason. There is no reason: no class from spring-webflux is imported. There is one import of org.springframework.web.client.ResponseErrorHandler, but it's provided by much smaller spring-web. So the dependency should be on spring-web instead.

Environment
Spring AI 1.0.0 Release

Steps to reproduce
Check spring-ai-retry/pom.xml

Expected behavior
No spring-webflux dependency

Minimal Complete Reproducible example
N/A (dependencies issue)
pkubowicz added a commit to pkubowicz/spring-ai that referenced this issue May 23, 2025
@pkubowicz
build: Use spring-web instead of spring-webflux in spring-ai-retry
9eadbd7 
The dependency on spring-webflux was unnecessary, there was no code
inside spring-ai-retry that made use of it.

Also remove 'optional' from slf4j-api dependency (it's not optional,
if you don't have it on classpath, RetryUtils will fail to load).

Fixes spring-projects#3307
@pkubowicz pkubowicz linked a pull request May 23, 2025 that will close this issue
Open
pkubowicz added a commit to pkubowicz/spring-ai that referenced this issue May 23, 2025
@pkubowicz
build: Use spring-web instead of spring-webflux in spring-ai-retry
f8226f7 
The dependency on spring-webflux was unnecessary, there was no code
inside spring-ai-retry that made use of it.

Also remove 'optional' from slf4j-api dependency (it's not optional,
if you don't have it on classpath, RetryUtils will fail to load).

Fixes spring-projects#3307

Signed-off-by: Piotr Kubowicz <piotr.kubowicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Use spring-web instead of spring-webflux in spring-ai-retry pkubowicz/spring-ai
1 participant
@pkubowicz