build: Use spring-web instead of spring-webflux in spring-ai-retry #3308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency on spring-webflux was unnecessary, there was no code inside spring-ai-retry that made use of it. Also remove 'optional' from slf4j-api dependency (it's not optional, if you don't have it on classpath, RetryUtils will fail to load). Fixes spring-projects#3307 Signed-off-by: Piotr Kubowicz <piotr.kubowicz@gmail.com>
pkubowicz
force-pushed
the
retry-no-webflux
branch
from
9eadbd7 to
f8226f7
Compare
bog-sb
approved these changes
May 23, 2025
|
Thanks, great catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency on spring-webflux was unnecessary, there was no code inside spring-ai-retry that made use of it.
Also remove 'optional' from slf4j-api dependency (it's not optional, if you don't have it on classpath, RetryUtils will fail to load).
Fixes #3307