Skip to content

Commit 63bcbc4

Browse files
committed
Move Zipkin testcontainers support into spring-boot-zipkin
1 parent a028983 commit 63bcbc4

File tree

8 files changed

+16
-7
lines changed

8 files changed

+16
-7
lines changed

spring-boot-project/spring-boot-testcontainers-all/src/main/resources/META-INF/spring.factories

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@ org.springframework.boot.testcontainers.service.connection.otlp.GrafanaOpenTelem
55
org.springframework.boot.testcontainers.service.connection.otlp.GrafanaOpenTelemetryTracingContainerConnectionDetailsFactory,\
66
org.springframework.boot.testcontainers.service.connection.otlp.OpenTelemetryLoggingContainerConnectionDetailsFactory,\
77
org.springframework.boot.testcontainers.service.connection.otlp.OpenTelemetryMetricsContainerConnectionDetailsFactory,\
8-
org.springframework.boot.testcontainers.service.connection.otlp.OpenTelemetryTracingContainerConnectionDetailsFactory,\
9-
org.springframework.boot.testcontainers.service.connection.zipkin.ZipkinContainerConnectionDetailsFactory
8+
org.springframework.boot.testcontainers.service.connection.otlp.OpenTelemetryTracingContainerConnectionDetailsFactory

spring-boot-project/spring-boot-zipkin/build.gradle

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
plugins {
22
id "java-library"
33
id "org.springframework.boot.auto-configuration"
4+
id "org.springframework.boot.docker-test"
45
id "org.springframework.boot.configuration-properties"
56
id "org.springframework.boot.deployed"
67
id "org.springframework.boot.optional-dependencies"
@@ -13,9 +14,15 @@ dependencies {
1314
api("io.zipkin.reporter2:zipkin-reporter-brave")
1415

1516
optional(project(":spring-boot-project:spring-boot-autoconfigure"))
17+
optional(project(":spring-boot-project:spring-boot-testcontainers"))
1618
optional("io.zipkin.reporter2:zipkin-reporter-brave")
1719

20+
dockerTestImplementation(project(":spring-boot-project:spring-boot-test"))
21+
dockerTestImplementation(project(":spring-boot-project:spring-boot-tools:spring-boot-test-support-docker"))
22+
dockerTestImplementation("org.testcontainers:junit-jupiter")
23+
1824
testImplementation(project(":spring-boot-project:spring-boot-test"))
1925
testImplementation(project(":spring-boot-project:spring-boot-tools:spring-boot-test-support"))
26+
testImplementation(testFixtures(project(":spring-boot-project:spring-boot-testcontainers")))
2027
testImplementation("com.squareup.okhttp3:mockwebserver")
2128
}
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.testcontainers.service.connection.zipkin;
17+
package org.springframework.boot.zipkin.testcontainers;
1818

1919
import org.junit.jupiter.api.Test;
2020
import org.testcontainers.containers.GenericContainer;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.testcontainers.service.connection.zipkin;
17+
package org.springframework.boot.zipkin.testcontainers;
1818

1919
import org.testcontainers.containers.Container;
2020
import org.testcontainers.containers.GenericContainer;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@
1717
/**
1818
* Support for testcontainers Zipkin service connections.
1919
*/
20-
package org.springframework.boot.testcontainers.service.connection.zipkin;
20+
package org.springframework.boot.zipkin.testcontainers;
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Connection Details Factories
2+
org.springframework.boot.autoconfigure.service.connection.ConnectionDetailsFactory=\
3+
org.springframework.boot.zipkin.testcontainers.ZipkinContainerConnectionDetailsFactory
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.testcontainers.service.connection.zipkin;
17+
package org.springframework.boot.zipkin.testcontainers;
1818

1919
import org.junit.jupiter.api.Test;
2020

Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.testcontainers.service.connection.zipkin;
17+
package org.springframework.boot.zipkin.testcontainers;
1818

1919
import org.junit.jupiter.api.Test;
2020

0 commit comments

Comments
 (0)