Skip to content

Commit a15a6fd

Browse files
committed
Move Zipkin Docker Compose support into spring-boot-zipkin
1 parent 63bcbc4 commit a15a6fd

File tree

7 files changed

+9
-8
lines changed

7 files changed

+9
-8
lines changed

spring-boot-project/spring-boot-docker-compose-all/src/main/resources/META-INF/spring.factories

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@
22
org.springframework.boot.autoconfigure.service.connection.ConnectionDetailsFactory=\
33
org.springframework.boot.docker.compose.service.connection.otlp.OpenTelemetryLoggingDockerComposeConnectionDetailsFactory,\
44
org.springframework.boot.docker.compose.service.connection.otlp.OpenTelemetryMetricsDockerComposeConnectionDetailsFactory,\
5-
org.springframework.boot.docker.compose.service.connection.otlp.OpenTelemetryTracingDockerComposeConnectionDetailsFactory,\
6-
org.springframework.boot.docker.compose.service.connection.zipkin.ZipkinDockerComposeConnectionDetailsFactory
5+
org.springframework.boot.docker.compose.service.connection.otlp.OpenTelemetryTracingDockerComposeConnectionDetailsFactory

spring-boot-project/spring-boot-zipkin/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@ dependencies {
1414
api("io.zipkin.reporter2:zipkin-reporter-brave")
1515

1616
optional(project(":spring-boot-project:spring-boot-autoconfigure"))
17+
optional(project(":spring-boot-project:spring-boot-docker-compose"))
1718
optional(project(":spring-boot-project:spring-boot-testcontainers"))
1819
optional("io.zipkin.reporter2:zipkin-reporter-brave")
1920

2021
dockerTestImplementation(project(":spring-boot-project:spring-boot-test"))
2122
dockerTestImplementation(project(":spring-boot-project:spring-boot-tools:spring-boot-test-support-docker"))
23+
dockerTestImplementation(testFixtures(project(":spring-boot-project:spring-boot-docker-compose")))
2224
dockerTestImplementation("org.testcontainers:junit-jupiter")
2325

2426
testImplementation(project(":spring-boot-project:spring-boot-test"))
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.docker.compose.service.connection.zipkin;
17+
package org.springframework.boot.zipkin.docker.compose;
1818

1919
import org.springframework.boot.docker.compose.service.connection.test.DockerComposeTest;
2020
import org.springframework.boot.testsupport.container.TestImage;
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.docker.compose.service.connection.zipkin;
17+
package org.springframework.boot.zipkin.docker.compose;
1818

1919
import org.springframework.boot.docker.compose.core.RunningService;
2020
import org.springframework.boot.docker.compose.service.connection.DockerComposeConnectionDetailsFactory;
@@ -35,8 +35,7 @@ class ZipkinDockerComposeConnectionDetailsFactory
3535
private static final int ZIPKIN_PORT = 9411;
3636

3737
ZipkinDockerComposeConnectionDetailsFactory() {
38-
super("openzipkin/zipkin",
39-
"org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinAutoConfiguration");
38+
super("openzipkin/zipkin", "org.springframework.boot.zipkin.autoconfigure.ZipkinAutoConfiguration");
4039
}
4140

4241
@Override
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@
1515
*/
1616

1717
/**
18-
* Auto-configuration for Docker Compose Zipkin service connections.
18+
* Support for Docker Compose Zipkin service connections.
1919
*/
20-
package org.springframework.boot.docker.compose.service.connection.zipkin;
20+
package org.springframework.boot.zipkin.docker.compose;
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
# Connection Details Factories
22
org.springframework.boot.autoconfigure.service.connection.ConnectionDetailsFactory=\
3+
org.springframework.boot.zipkin.docker.compose.ZipkinDockerComposeConnectionDetailsFactory,\
34
org.springframework.boot.zipkin.testcontainers.ZipkinContainerConnectionDetailsFactory

0 commit comments

Comments
 (0)