Skip to content

Remove isImmutable and getPrefix from OriginLookup #45547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
philwebb opened this issue May 14, 2025 · 2 comments
Open

Remove isImmutable and getPrefix from OriginLookup #45547

philwebb opened this issue May 14, 2025 · 2 comments
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Milestone
4.0.x

Comments

@philwebb
Copy link
Member

The OriginLookup interface has isImmutable and getPrefix methods that were added to fix a package tangle. They don't really belong in this interface and it would be good to find a better way to solve the problem in 4.0
@philwebb philwebb added type: enhancement A general enhancement status: pending-design-work Needs design work before any code can be developed labels May 14, 2025
@philwebb philwebb added this to the 4.0.x milestone May 14, 2025
@philwebb
Copy link
Member Author

We might also want to look at the fix for #45387

@philwebb
Copy link
Member Author

Changing EnvironmentPostProcessor might be the best way to do this. Perhaps supporting SpringApplication as a constructor argument or moving the interface somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
Milestone
4.0.x
Development

No branches or pull requests
1 participant
@philwebb