Skip to content

Allow primitive repository args for DynamicProxyable repositories.. #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Allow primitive repository args for DynamicProxyable repositories.. #1972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/org/springframework/data/couchbase/repository/support/FindMethod.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,14 @@ private static Method internalFind(Method[] toTest, String name, Class[] paramet
}
int j;
for (j = 0; j < l; j++) {
if(params[j] == int.class && parameterTypes[j] == Integer.class )
continue;
if(params[j] == long.class && parameterTypes[j] == Long.class )
continue;
if(params[j] == double.class && parameterTypes[j] == Double.class )
continue;
if(params[j] == boolean.class && parameterTypes[j] == Boolean.class )
continue;
if (!params[j].isAssignableFrom(parameterTypes[j]))
break;
}
Expand Down
3 changes: 3 additions & 0 deletions src/test/java/org/springframework/data/couchbase/domain/ReactiveAirportRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ public interface ReactiveAirportRepository
@ScanConsistency(query = QueryScanConsistency.REQUEST_PLUS)
Flux<Airport> findAll();

@Query("#{#n1ql .selectEntity} WHERE #{#n1ql.filter} ORDER BY $3 $4 LIMIT $1 OFFSET $2 ")
Flux<Airport> findAllTestPrimitives(int iint, long llong, double ddouble, boolean bbolean);

@Override
@ScanConsistency(query = QueryScanConsistency.REQUEST_PLUS)
Mono<Void> deleteAll();
Expand Down
16 changes: 10 additions & 6 deletions ...framework/data/couchbase/repository/ReactiveCouchbaseRepositoryQueryIntegrationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,26 +41,20 @@

import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.context.annotation.Configuration;
import org.springframework.dao.DataRetrievalFailureException;
import org.springframework.dao.OptimisticLockingFailureException;
import org.springframework.data.couchbase.CouchbaseClientFactory;
import org.springframework.data.couchbase.config.AbstractCouchbaseConfiguration;
import org.springframework.data.couchbase.domain.Airport;
import org.springframework.data.couchbase.domain.ReactiveAirportRepository;
import org.springframework.data.couchbase.domain.ReactiveUserRepository;
import org.springframework.data.couchbase.domain.User;
import org.springframework.data.couchbase.repository.config.EnableReactiveCouchbaseRepositories;
import org.springframework.data.couchbase.util.Capabilities;
import org.springframework.data.couchbase.util.ClusterType;
import org.springframework.data.couchbase.util.IgnoreWhen;
import org.springframework.data.couchbase.util.JavaIntegrationTests;
import org.springframework.data.domain.PageRequest;
import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;

import com.couchbase.client.core.deps.io.netty.handler.ssl.util.InsecureTrustManagerFactory;
import com.couchbase.client.core.env.SecurityConfig;
import com.couchbase.client.java.env.ClusterEnvironment;

/**
* template class for Reactive Couchbase operations
Expand Down Expand Up @@ -99,6 +93,16 @@ void shouldSaveAndFindAll() {
}
}

@Test
void testPrimitiveArgs() {
int iint = 0;
long llong = 0;
double ddouble = 0.0;
boolean bboolean = true;
List<Airport> all = reactiveAirportRepository.withScope("_default")
.findAllTestPrimitives(iint, llong, ddouble, bboolean).toStream().collect(Collectors.toList());
}

@Test
void testQuery() {
Airport vie = null;
Expand Down
Loading