Skip to content

gh-32154: BeanWrapper - fix autogrow for nested maps #34905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -649,11 +649,14 @@ else if (value instanceof List list) {
value = list.get(index);
}
else if (value instanceof Map map) {
Class<?> mapKeyType = ph.getResolvableType().getNested(i + 1).asMap().resolveGeneric(0);
ResolvableType mapResolvableType = ph.getResolvableType().getNested(i + 1).asMap();
Class<?> mapKeyType = mapResolvableType.resolveGeneric(0);
Class<?> mapValueType = mapResolvableType.resolveGeneric(1);
// IMPORTANT: Do not pass full property name in here - property editors
// must not kick in for map keys but rather only for map values.
TypeDescriptor typeDescriptor = TypeDescriptor.valueOf(mapKeyType);
Object convertedMapKey = convertIfNecessary(null, null, key, mapKeyType, typeDescriptor);
growMapIfNecessary(map, convertedMapKey, mapValueType, indexedPropertyName.toString());
value = map.get(convertedMapKey);
}
else if (value instanceof Iterable iterable) {
Expand Down Expand Up @@ -792,6 +795,17 @@ private void growCollectionIfNecessary(Collection<Object> collection, int index,
}
}

private void growMapIfNecessary(Map<Object, Object> map, @Nullable Object convertedMapKey,
@Nullable Class<?> mapValueType, String name) {

if (mapValueType == null || !isAutoGrowNestedPaths()) {
return;
}
if (!map.containsKey(convertedMapKey) && map.size() < this.autoGrowCollectionLimit) {
map.put(convertedMapKey, newValue(mapValueType, null, name));
}
}

/**
* Get the last component of the path. Also works if not nested.
* @param pa property accessor to work on
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import java.util.Map;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThat;
Expand Down Expand Up @@ -200,6 +199,13 @@ void getPropertyValueAutoGrowNestedNestedList() {
assertThat(bean.getNestedNestedList().get(0).get(0)).singleElement().isInstanceOf(Bean.class);
}

@Test
void getPropertyValueAutoGrowNestedNestedMap() {
assertThat(wrapper.getPropertyValue("nestedNestedMap[A][B][C]")).isNotNull();
assertThat(bean.getNestedNestedMap()).hasSize(1);
assertThat(bean.getNestedNestedMap().get("A").get("B").get("C")).isInstanceOf(Bean.class);
}

@Test
void getPropertyValueAutoGrowListNotParameterized() {
assertThatExceptionOfType(InvalidPropertyException.class).isThrownBy(() ->
Expand All @@ -224,7 +230,7 @@ void setPropertyValueAutoGrowNestedMapWithinMap() {
assertThat(bean.getNestedMap().get("A").get("B")).isInstanceOf(Bean.class);
}

@Test @Disabled // gh-32154
@Test
void setPropertyValueAutoGrowNestedNestedMapWithinMap() {
wrapper.setPropertyValue("nestedNestedMap[A][B][C]", new Bean());
assertThat(bean.getNestedNestedMap().get("A").get("B").get("C")).isInstanceOf(Bean.class);
Expand Down