Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in JDK Version #253

Open
iSoftech opened this issue Sep 7, 2024 · 3 comments
Open

Typo in JDK Version #253

iSoftech opened this issue Sep 7, 2024 · 3 comments

Comments

@iSoftech
Copy link

iSoftech commented Sep 7, 2024

Is the version mentioned in this line is the right version or the one mentioned in the title i.e. JDK17? The below line states jdk1.7.0.

https://github.com/spring-projects/spring-security-kerberos/blame/e07f0036dfcc6c105edfba84bdef4ce543040169/README.adoc#L29

@dodgex
Copy link

dodgex commented Sep 10, 2024

You linked even with the blame... there you can see, that this line was added 9 years ago. So I am sure, it was intended to have 1.7.0 (aka Java 7) mentioned.

I think the readme is (partially?) as deprecated as the https://github.com/spring-projects/spring-security-kerberos/blob/main/CONTRIBUTING.md is that links to JIRA that is long gone.

@iSoftech
Copy link
Author

Yes, I agree, but the title says JDK17 which makes me wonder if it still supports the older version of JDK or it expects latest packages like Spring 6+ / SpringBoot 3+ and JDK17+.

@dodgex
Copy link

dodgex commented Sep 11, 2024

According to this file it seems that the the latest version requires Spring 6.1+ and Spring Security 6.3+. At least it builds against these versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants