Fix typo causing too big export windows

springfall2008 · springfall2008 · commit fde68a5c9bf1 · 2025-05-31T20:54:10.000+01:00
diff --git a/apps/predbat/plan.py b/apps/predbat/plan.py
@@ -2703,7 +2703,8 @@ def optimise_detailed_pass(
                                         window_n, self.time_abs_str(self.end_record + self.minutes_now), best_price_charge, best_price_export, lowest_price_charge, self.charge_limit_best, self.export_limits_best
                                     )
                                 )
-
+                            # Try to optimise the export window
+                            keep_start = self.export_window_best[window_n]["start"]
                             self.export_window_best[window_n]["start"] = self.export_window_best[window_n].get("start_orig", self.export_window_best[window_n]["start"])
                             n_best_soc, n_best_start, n_best_metric, n_best_cost, n_soc_min, n_soc_min_minute, n_best_keep, n_best_cycle, n_best_carbon, n_best_import = self.optimise_export(
                                 window_n,
@@ -2716,6 +2717,7 @@ def optimise_detailed_pass(
                                 freeze_only=(typ == "df") or pass_type == "freeze",
                                 allow_freeze=True,
                             )
+                            self.export_window_best[window_n]["start"] = keep_start
                             if n_best_metric <= best_metric and (n_best_soc != self.export_limits_best[window_n] or n_best_start != self.export_window_best[window_n]["start"]):
                                 best_metric = n_best_metric
                                 best_cost = n_best_cost

Original file line number	Diff line number	Diff line change
`@@ -2703,7 +2703,8 @@ def optimise_detailed_pass(`
`2703`	`2703`	`window_n, self.time_abs_str(self.end_record + self.minutes_now), best_price_charge, best_price_export, lowest_price_charge, self.charge_limit_best, self.export_limits_best`
`2704`	`2704`	`)`
`2705`	`2705`	`)`
`2706`		`-`
	`2706`	`+ # Try to optimise the export window`
	`2707`	`+ keep_start = self.export_window_best[window_n]["start"]`
`2707`	`2708`	`self.export_window_best[window_n]["start"] = self.export_window_best[window_n].get("start_orig", self.export_window_best[window_n]["start"])`
`2708`	`2709`	`n_best_soc, n_best_start, n_best_metric, n_best_cost, n_soc_min, n_soc_min_minute, n_best_keep, n_best_cycle, n_best_carbon, n_best_import = self.optimise_export(`
`2709`	`2710`	`window_n,`
`@@ -2716,6 +2717,7 @@ def optimise_detailed_pass(`
`2716`	`2717`	`freeze_only=(typ == "df") or pass_type == "freeze",`
`2717`	`2718`	`allow_freeze=True,`
`2718`	`2719`	`)`
	`2720`	`+ self.export_window_best[window_n]["start"] = keep_start`
`2719`	`2721`	`if n_best_metric <= best_metric and (n_best_soc != self.export_limits_best[window_n] or n_best_start != self.export_window_best[window_n]["start"]):`
`2720`	`2722`	`best_metric = n_best_metric`
`2721`	`2723`	`best_cost = n_best_cost`