Add prices to text description, disable left over debug text #2405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the logging and textual output to remove leftover debug messages and add price estimations in user-facing text.
- Removed an unguarded debug log in plan.py and added conditional logging based on self.debug_enable.
- Enhanced the output message in output.py to include estimated bill amounts for today and tomorrow, and updated the string concatenation for import rate details.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/plan.py | Removed an extraneous debug log and wrapped a debug log call with a condition. |
| apps/predbat/output.py | Added calculations and formatting for price estimates; adjusted string concatenation for import rate details. |
Comment on lines
+826
to
+827
| midnight_today_minute = 24 * 60 - self.minutes_now | ||
| midnight_tomorrow_minute = 24 * 60 + midnight_today_minute |
There was a problem hiding this comment.
Consider defining a named constant (e.g., MINUTES_IN_DAY) instead of using the magic number '24 * 60' to improve code readability and maintainability.
Suggested change
| midnight_today_minute = 24 * 60 - self.minutes_now | |
| midnight_tomorrow_minute = 24 * 60 + midnight_today_minute | |
| midnight_today_minute = MINUTES_IN_DAY - self.minutes_now | |
| midnight_tomorrow_minute = MINUTES_IN_DAY + midnight_today_minute |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.