fix based on review comments

Author: kane8n

api/v1alpha1/groupversion_info.go

@@ -15,8 +15,8 @@ limitations under the License.
 */
 
 // Package v1alpha1 contains API Schema definitions for the gatling-operator v1alpha1 API group
-//+kubebuilder:object:generate=true
-//+groupName=gatling-operator.tech.zozo.com
+// +kubebuilder:object:generate=true
+// +groupName=gatling-operator.tech.zozo.com
 package v1alpha1
 
 import (

controllers/gatling_controller.go

@@ -143,7 +143,7 @@ func (r *GatlingReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 
 // Implementation of reconciler logic for the runner job
 func (r *GatlingReconciler) gatlingRunnerReconcile(ctx context.Context, req ctrl.Request, gatling *gatlingv1alpha1.Gatling, log logr.Logger) (bool, error) {
-	if err := r.createObjectsForCR(ctx, gatling, req.Namespace, log); err != nil {
+	if err := r.createVolumesForCR(ctx, gatling, req.Namespace, log); err != nil {
 		return true, err
 	}
 	if gatling.Status.RunnerJobName == "" {
@@ -370,7 +370,7 @@ func doNotRequeue(err error) (ctrl.Result, error) {
 	return ctrl.Result{}, err
 }
 
-func (r *GatlingReconciler) createObjectsForCR(ctx context.Context, gatling *gatlingv1alpha1.Gatling, namespace string, log logr.Logger) error {
+func (r *GatlingReconciler) createVolumesForCR(ctx context.Context, gatling *gatlingv1alpha1.Gatling, namespace string, log logr.Logger) error {
 	// Create Simulation Data ConfigMap if defined to create in CR
 	if &gatling.Spec.TestScenarioSpec.SimulationData != nil && len(gatling.Spec.TestScenarioSpec.SimulationData) > 0 {
 		configMapName := gatling.Name + "-simulations-data"
@@ -419,14 +419,14 @@ func (r *GatlingReconciler) createObjectsForCR(ctx context.Context, gatling *gat
 	// Create PersistentVolume if defined to create in CR
 	if &gatling.Spec.PersistentVolumeSpec != nil && gatling.Spec.PersistentVolumeSpec.Name != "" {
 		volumeName := gatling.Spec.PersistentVolumeSpec.Name
-		foundVolue := &corev1.PersistentVolume{}
-		if err := r.Get(ctx, client.ObjectKey{Name: volumeName, Namespace: namespace}, foundVolue); err != nil {
+		foundVolume := &corev1.PersistentVolume{}
+		if err := r.Get(ctx, client.ObjectKey{Name: volumeName, Namespace: namespace}, foundVolume); err != nil {
 			if !apierr.IsNotFound(err) {
 				return err
 			}
 			persistentVolume := r.newPersistentVolumeForCR(gatling, volumeName, &gatling.Spec.PersistentVolumeSpec.Spec)
 			if err := r.createObject(ctx, gatling, persistentVolume); err != nil {
-				log.Error(err, fmt.Sprintf("Failed to creating new PersistentVolume: namespace %s name %s", gatling.GetNamespace(), volumeName))
+				log.Error(err, fmt.Sprintf("Failed to creating new PersistentVolume: namespace %s name %s", persistentVolume.GetNamespace(), volumeName))
 				return err
 			}
 		}
@@ -441,7 +441,7 @@ func (r *GatlingReconciler) createObjectsForCR(ctx context.Context, gatling *gat
 			}
 			persistentVolumeClaim := r.newPersistentVolumeClaimForCR(gatling, claimName, &gatling.Spec.PersistentVolumeClaimSpec.Spec)
 			if err := r.createObject(ctx, gatling, persistentVolumeClaim); err != nil {
-				log.Error(err, fmt.Sprintf("Failed to creating new PersistentVolumeClaim: namespace %s name %s", gatling.GetNamespace(), claimName))
+				log.Error(err, fmt.Sprintf("Failed to creating new PersistentVolumeClaim: namespace %s name %s", persistentVolumeClaim.GetNamespace(), claimName))
 				return err
 			}
 		}

docs/user-guide.md

@@ -55,7 +55,7 @@ For `Gatling load testing related files`, you have 3 options:
 
 - Create custom image to bundle Gatling load testing files with Java runtime and Gatling standalone bundle package
 - Add Gatling load testing files as multi-line definitions in `.spec.testScenatioSpec` part of `Gatling CR`
-- Set up persistent volumes in `.persistentVolume` and `.persistentVolumeClaim` in `Gatling CR` and load test files from the persistent volumes in Gatling load test files.
+- Set up persistent volume in `.persistentVolume` and `.persistentVolumeClaim` in `Gatling CR` and load test files from the persistent volume in Gatling load test files.
 
 ### Create Custom Gatling Image to bundle Gatling Load Testing Files