Allow empty strings in datetime intervals #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitner
approved these changes
Feb 2, 2023
|
Thanks @gadomski! Every release gets a new version as each release needs to have a migration generated for it. I'm refactoring some things for 0.7.0 that will make running tests between releases much more easy (right now, you have to have a migration in order to run the tests). If you mark this as ready to review, I'll merge it and make sure it gets incorporated into the 0.7.0 release. |
bitner
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Description
Adds support for empty strings in datetime intervals, e.g.
2023-02-02/. Includes tests.I'm opening this as a draft PR b/c I'm not sure of the correct process to propogate these changes to the actual files that get run (e.g.) when you do
scripts/test. To test locally, I made a new version w/ my modifications. Does every PR get a new version?