Skip to content

Commit c02a878

Browse files
ieedanAidan Bleser
and
Aidan Bleser
authored
fix: Correct typo in --bin flag (#346)
Co-authored-by: Aidan Bleser <ieedan@Aidans-MacBook-Pro.local>
1 parent e80f8d8 commit c02a878

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

Diff for: README.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -146,15 +146,17 @@ npm i https://pkg.pr.new/tinylibs/tinybench/tinybench@a832a55
146146
For CLI applications you might want to show `npx` instead of `npm i` for the preview command. This can be accomplished with the `--bin` flag:
147147

148148
```sh
149-
npx pkg-pr-new publish --bin
149+
npx pkg-pr-new publish --bin
150150
```
151151

152152
With `--bin`:
153+
153154
```sh
154155
npx https://pkg.pr.new/pkg-pr-new@a832a55
155156
```
156157

157158
Without `--bin`:
159+
158160
```sh
159161
npm i https://pkg.pr.new/pkg-pr-new@a832a55
160162
```

Diff for: packages/backend/server/routes/publish.post.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ export default eventHandler(async (event) => {
207207
workflowData,
208208
compact,
209209
packageManager,
210-
bin
210+
bin,
211211
),
212212
},
213213
conclusion: "success",
@@ -264,7 +264,7 @@ export default eventHandler(async (event) => {
264264
checkRunUrl,
265265
packageManager,
266266
"ref",
267-
bin
267+
bin,
268268
),
269269
},
270270
);
@@ -285,7 +285,7 @@ export default eventHandler(async (event) => {
285285
checkRunUrl,
286286
packageManager,
287287
comment === "update" ? "ref" : "sha",
288-
bin
288+
bin,
289289
),
290290
},
291291
);

Diff for: packages/cli/index.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,7 @@ const main = defineCommand({
130130

131131
const isPeerDepsEnabled = !!args.peerDeps;
132132
const isOnlyTemplates = !!args["only-templates"];
133-
134-
const isBinaryApplication = !!args.binaryApplication;
133+
const isBinaryApplication = !!args.bin;
135134
const comment: Comment = args.comment as Comment;
136135
const selectedPackageManager = args.packageManager as
137136
| "npm"

0 commit comments

Comments
 (0)