Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github action #341

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

mmkal
Copy link
Contributor

@mmkal mmkal commented Mar 5, 2025

Fixes #225

@Aslemammad tried out the simplest thing I could think of and it seems to work. Example usage (note that pkg-pr-new is no longer installed in package.json etc.): mmkal/expect-type#146

What would be needed for this to be merge-worthy:

  • Docs
  • Some idea of release strategy - github actions should be semver'd, which could work nicely since this is an npm package too, but then you'd want to tie the version of the action being used to the npm package installed, rather than assume latest which could be confusing
  • Decide if args is good enough for the CLI args. I went for the second option I suggested in GitHub Action? #225 (comment) since it adds basically no maintenance overhead

I do think it makes for a nicer experience. pkg-pr-new should really be only used from a CI runner, right? So it seems like it's good signal to people to use it that way. uses: stackblit-labs/pkg.pr.new... gives more confidence than npx -y pkg-pr-new@latest ... I reckon. Plus tools like renovate will automatically upgrade it this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action?
1 participant