Fix/summarizer #16
Merged
Fix/summarizer #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…min and extractor APIs
… timeout handling
…ance documentation
…c with optional key-value store removal
…ns in upload_source function
…-library into onapitorulethemall
…e unused managed_page_summary_enhancer module
…r DefaultSourceUploader to use it refactor: update JSON serialization in ExtractionParameters, ExtractionRequest, InformationPiece, and KeyValuePair models refactor: remove unused test files for confluence and thread management integration
…load_source function
…tionPiece classes
…ece classes to support sitemap extraction
…andle JSON header templates
…mprove parameter handling
…rsing and meta functions
…ustom parsing functions
…ved configurability
manu-hoffmann
approved these changes
Jun 6, 2025
manu-hoffmann
approved these changes
Jun 6, 2025
MirUlr
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the
PageSummaryEnhancerclass inadmin-api-lib/src/admin_api_lib/impl/information_enhancer/page_summary_enhancer.py. The changes focus on improving the logic for summarizing pages by restructuring the grouping mechanism and adding a new method for summarizing page content asynchronously.Enhancements to page summarization:
_asummarize_pageto asynchronously summarize the content of grouped page pieces. This method combines page content, invokes the summarizer, and constructs metadata with additional attributes such as a unique ID and related document IDs.Refactoring of page grouping logic:
_acreate_summarywith a new approach that explicitly identifies distinct pages and groups information pieces based on their page metadata. The new logic also filters out groups that do not meet the chunk size threshold whenself._chunker_settingsis enabled.