Skip to content

Commit

Permalink
Allow blacklisting broken, but published services (#130)
Browse files Browse the repository at this point in the history
* fix: Allow blacklisting broken, but published services

* fix: Add blacklisting for python generation as well

* fix: disable unsupported go versions to unblock pipeline

* disable go 1.23 for test

* separate build/test and linting steps
  • Loading branch information
bahkauv70 authored Feb 20, 2025
1 parent 67bdbcd commit 5eed445
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 5 deletions.
40 changes: 35 additions & 5 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
go-version: ["1.18", "1.19", "1.20", "1.21", "1.22"]
go-version: ["1.21", "1.22", "1.23"]
runs-on: ${{ matrix.os }}
steps:
- name: Install SSH Key
Expand All @@ -37,13 +37,43 @@ jobs:
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
- name: Lint
if: ${{ matrix.go-version == '1.19' || matrix.go-version == '1.20' || matrix.go-version == '1.21' || matrix.go-version == '1.22'}}
working-directory: ./sdk-repo-updated
run: make lint skip-non-generated-files=true
- name: Test
working-directory: ./sdk-repo-updated
run: make test skip-non-generated-files=true

lint-go:
name: CI [Go]
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}
steps:
- name: Install SSH Key
uses: shimataro/ssh-key-action@v2
with:
key: ${{ secrets.SSH_PRIVATE_KEY }}
known_hosts: ${{ vars.SSH_KNOWN_HOSTS }}
- name: Install Java
uses: actions/setup-java@v4
with:
distribution: "temurin"
java-version: ${{ env.JAVA_VERSION }}
- name: Checkout
uses: actions/checkout@v4
- name: Build
uses: ./.github/actions/build/go
with:
go-version: ${{ env.GO_VERSION_BUILD }}
- name: Generate SDK
uses: ./.github/actions/generate-sdk/go
- name: Install Go ${{ env.GO_VERSION_BUILD }}
uses: actions/setup-go@v5
with:
go-version: ${{ env.GO_VERSION_BUILD }}
- name: Lint
working-directory: ./sdk-repo-updated
run: make lint skip-non-generated-files=true

main-python:
name: CI [Python]
strategy:
Expand Down
3 changes: 3 additions & 0 deletions blacklist.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Transitional file to force generation of the new regional api for selected services
# It will be removed when all services have been migrated to the new regional api
modelserving
5 changes: 5 additions & 0 deletions scripts/generate-sdk/languages/go.sh
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,11 @@ generate_go_sdk() {
exit 1
fi

if grep -E "^$service$" ${ROOT_DIR}/blacklist.txt; then
echo "Skipping blacklisted service ${service}"
continue
fi

echo -e "\n>> Generating \"${service}\" service..."
cd ${ROOT_DIR}

Expand Down
5 changes: 5 additions & 0 deletions scripts/generate-sdk/languages/python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ generate_python_sdk() {
service=$(echo "${service}" | tr '[:upper:]' '[:lower:]') # convert upper case letters to lower case
service=$(echo "${service}" | tr -d -c '[:alnum:]') # remove non-alphanumeric characters

if grep -E "^$service$" ${ROOT_DIR}/blacklist.txt; then
echo "Skipping blacklisted service ${service}"
continue
fi

echo ">> Generating \"${service}\" service..."
cd ${ROOT_DIR}

Expand Down

0 comments on commit 5eed445

Please sign in to comment.