-
Notifications
You must be signed in to change notification settings - Fork 219
Update cryptography.adoc #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cryptography.adoc #1625
Conversation
Oops, your pull request failed to pass the Typo tests stage :( . see the result: Please fix the typo, commit and push! |
Oops, your pull request failed to pass the Typo tests stage :( . see the result: Please fix the typo, commit and push! |
Oops, your pull request failed to pass the Typo tests stage :( . see the result: Please fix the typo, commit and push! |
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1625/ . |
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1625/ . |
1 similar comment
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1625/ . |
Hey @feltroidprime, thanks for the contribution 🙏
|
1 . It can be verified by pasting this SageMath snippet ( https://sagecell.sagemath.org/ ) :
output:
The order of an elliptic is a standard information, for most (if not all) algorithms using an elliptic curve, the order is needed (signatures like ecdsa, zk-proof, etc). See https://github.com/xJonathanLEI/starknet-rs/blob/194631520a02ce0f0b7c7bd3784831047bc43eac/starknet-crypto/src/rfc6979.rs#L7 for example. |
Got it, thanks for the clarification, and thanks again for the contribution! |
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1625/ . |
Description of the Changes
Add information about the curve order.
PR Preview URL
https://starknet-io.github.io/starknet-docs/pr-1625/architecture-and-concepts/cryptography/#the_stark_curve
Check List
minor typos fix in README
This change is