FR: Loosen up the templating of product_variants tag #126
Closed
ncla
started this conversation in
Feature Requests
Replies: 2 comments 1 reply
-
@ncla Sure, it's meant to be quite tight at the moment but I could see the use case. Happy for a PR to tackle this. |
Beta Was this translation helpful? Give feedback.
0 replies
-
I've opened a PR here for that #173 |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Right now if you want to change the markup of the
<select>
coming fromproduct_variants
tag then you must create basically another tag and duplicate this addons tag code. The methods responsible for creating the markup areprivate
, and I cannot simply extend the ProductVariants tag class and just overrideparseOptions
, where I could add the HTML attribute I want. Ideally, in my opinion, this templating should be moved to antlers or blade templates.Beta Was this translation helpful? Give feedback.
All reactions