Skip to content

Use optimised rlp hash writer in aristo_compute #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arnetheduck opened this issue Mar 25, 2025 · 1 comment
Open

Use optimised rlp hash writer in aristo_compute #3164

arnetheduck opened this issue Mar 25, 2025 · 1 comment
Assignees

Comments

@arnetheduck
Copy link
Member

computeKey is one of the places where we compute the most hashes that would benefit from avoiding memory allocations (since they're numerous and small), and yet the new HashWriter is not in use there:

var writer = initRlpWriter()

@arnetheduck
Copy link
Member Author

More here: https://github.com/status-im/nim-eth/blob/37bf6db28b81e3cd45a101457bc6909d9081c4b4/eth/common/transactions_rlp.nim#L238

basically, need to grep the codebase for any rlp interactions that we can get rid of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants